Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenWRT version needs shorter query log retention options due to free space limitations #2504

Closed
3 tasks done
egalitarian opened this issue Dec 29, 2020 · 5 comments
Closed
3 tasks done
Assignees
Milestone

Comments

@egalitarian
Copy link

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Problem Description

The smallest query logs retention setting of 24h still creates a log far too big for most OpenWRT devices filling up all of the available space.

Proposed Solution

Adding option for 1h or any other smaller than 24h would allow to check all latest queries and still be of some use when debugging problems.

Alternatives Considered

An alternative would be to stop logging altogether and just start it from when you debug things but that would be more inconvenient.

Additional Information

@emlimap
Copy link

emlimap commented Jan 3, 2021

Another option that would be good to have rather than completely disable logging is to have limited in memory logs. This feature would be useful to extend the lifetime of sd card on SBC's like Raspberry Pi by not writing any logs to disk but have enough logs to troubleshoot blocked domains. Amount of logs held in memory can be set by user.

There is already a parameter querylog_size_memory which set the number of logs to queue up before it writes to disk. We could use this but not write to disk when logging is completed disabled

@ameshkov
Copy link
Member

ameshkov commented Jan 4, 2021

Another option that would be good to have rather than completely disable logging is to have limited in memory logs

As I recall, that's exactly what happens when querylog_file_enabled is set to false

@ameshkov ameshkov modified the milestones: v0.106.0, v0.107.0 Mar 3, 2021
adguard pushed a commit that referenced this issue Jul 1, 2021
Merge in DNS/adguard-home from 2504-querylog-ivl to master

Updates #2504.

Squashed commit of the following:

commit 5d15a6f
Merge: 8cd5c30 97073d0
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Thu Jul 1 18:45:10 2021 +0300

    Merge branch 'master' into 2504-querylog-ivl

commit 8cd5c30
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Thu Jul 1 18:35:50 2021 +0300

    client: fix fmt

commit e95d462
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Thu Jul 1 17:58:06 2021 +0300

    home: imp code

commit 48737b2
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Thu Jul 1 17:23:18 2021 +0300

    home: imp duration

commit 44f5dc3
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Thu Jul 1 16:55:31 2021 +0300

    home: imp code, docs

commit bb28265
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Thu Jul 1 16:11:40 2021 +0300

    all: imp code, docs

commit d688aed
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Thu Jul 1 13:49:42 2021 +0300

    all: change querylog interval setting format
@agneevX
Copy link
Contributor

agneevX commented Jul 2, 2021

Can this be documented in Raspberry Pi install instructions, @ameshkov? Would help users to a great extent, thanks.

@EugeneOne1
Copy link
Member

@egalitarian, you may now set 6h value for query logs retention period. It's available in the latest edge builds and in beta builds since v0.107.0-b.4. Could you please check if it fixes the situation?

@EugeneOne1
Copy link
Member

We'll close the issue for now. Please, feel free to reopen it if you'll face any problems with it.

heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Merge in DNS/adguard-home from 2504-querylog-ivl to master

Updates AdguardTeam#2504.

Squashed commit of the following:

commit 5d15a6f
Merge: 8cd5c30 97073d0
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Thu Jul 1 18:45:10 2021 +0300

    Merge branch 'master' into 2504-querylog-ivl

commit 8cd5c30
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Thu Jul 1 18:35:50 2021 +0300

    client: fix fmt

commit e95d462
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Thu Jul 1 17:58:06 2021 +0300

    home: imp code

commit 48737b2
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Thu Jul 1 17:23:18 2021 +0300

    home: imp duration

commit 44f5dc3
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Thu Jul 1 16:55:31 2021 +0300

    home: imp code, docs

commit bb28265
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Thu Jul 1 16:11:40 2021 +0300

    all: imp code, docs

commit d688aed
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Thu Jul 1 13:49:42 2021 +0300

    all: change querylog interval setting format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants