Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve type-safety JSON decoding and encoding #2509

Closed
ainar-g opened this issue Dec 31, 2020 · 0 comments
Closed

Improve type-safety JSON decoding and encoding #2509

ainar-g opened this issue Dec 31, 2020 · 0 comments
Assignees
@EugeneOne1
Labels
enhancement P4: Low
Milestone
v0.105.0

Comments

@ainar-g
Copy link
Contributor

ainar-g commented Dec 31, 2020

There are a few places where we usemap[string]interface{} instead of actual structures to decode and encode JSON. We should use strongly-types structs instead.
@ainar-g ainar-g added this to the v0.105.0 milestone Dec 31, 2020
adguard pushed a commit that referenced this issue Jan 20, 2021
@EugeneOne1
Pull request: 2509 type-safety vol.1
5a50efa 
Merge in DNS/adguard-home from 2509-type-safety to master

Updates #2509.

Squashed commit of the following:

commit 535968e
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Wed Jan 20 15:06:16 2021 +0300

    dhcpd: fix comments

commit dc79b80
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Wed Jan 20 14:08:10 2021 +0300

    all: improve docs

commit 156ebf6
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Jan 19 17:08:15 2021 +0300

    all: improve JSON encoding and decoding
adguard pushed a commit that referenced this issue Jan 21, 2021
@EugeneOne1
Pull request: 2509 type-safety vol.2
d9482b7 
Merge in DNS/adguard-home from 2509-type-safety-vol2 to master

Updates #2509.

Squashed commit of the following:

commit c944e4e
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Thu Jan 21 19:36:20 2021 +0300

    all: imp docs

commit e8ac181
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Wed Jan 20 12:38:48 2021 +0300

    all: imp JSON encoding, decoding
adguard pushed a commit that referenced this issue Jan 22, 2021
@EugeneOne1
Pull request: 2509 type-safety logs
fb9acf4 
Merge in DNS/adguard-home from 2509-type-safety-log to master

Updates #2509.

* commit '684017a75f918aa0dcd76792c34aecd35fa01b01':
  all: log changes
@ainar-g ainar-g mentioned this issue Feb 16, 2021
Closed
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 2509 type-safety vol.1
5ec1d77 
Merge in DNS/adguard-home from 2509-type-safety to master

Updates AdguardTeam#2509.

Squashed commit of the following:

commit 535968e
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Wed Jan 20 15:06:16 2021 +0300

    dhcpd: fix comments

commit dc79b80
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Wed Jan 20 14:08:10 2021 +0300

    all: improve docs

commit 156ebf6
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Jan 19 17:08:15 2021 +0300

    all: improve JSON encoding and decoding
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 2509 type-safety vol.2
e6eb7a7 
Merge in DNS/adguard-home from 2509-type-safety-vol2 to master

Updates AdguardTeam#2509.

Squashed commit of the following:

commit c944e4e
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Thu Jan 21 19:36:20 2021 +0300

    all: imp docs

commit e8ac181
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Wed Jan 20 12:38:48 2021 +0300

    all: imp JSON encoding, decoding
@GTVolk GTVolk mentioned this issue Mar 7, 2024
Open
@stnert stnert mentioned this issue Mar 7, 2024
Open
@smilers smilers mentioned this issue Mar 7, 2024
Closed
@GTVolk GTVolk mentioned this issue Mar 8, 2024
Open
@stnert stnert mentioned this issue Mar 9, 2024
Open
@smilers smilers mentioned this issue Mar 9, 2024
Closed
This was referenced Mar 13, 2024
Open
Open
Open
Open
@GTVolk GTVolk mentioned this issue Mar 22, 2024
Open
@SarmadBytes SarmadBytes mentioned this issue Mar 28, 2024
Open
@SarmadBytes SarmadBytes mentioned this issue Apr 16, 2024
Open
@SarmadBytes SarmadBytes mentioned this issue Apr 30, 2024
Open
This was referenced May 10, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
enhancement P4: Low
Projects
None yet
Milestone
v0.105.0
Development

No branches or pull requests
2 participants
@ainar-g @EugeneOne1