Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove/replace context.TODO() #2552

Closed
ainar-g opened this issue Jan 13, 2021 · 0 comments
Closed

Remove/replace context.TODO() #2552

ainar-g opened this issue Jan 13, 2021 · 0 comments
Assignees
@EugeneOne1
Labels
enhancement P4: Low
Milestone
v0.105.0

Comments

@ainar-g
Copy link
Contributor

ainar-g commented Jan 13, 2021

There are currently a few places where context.TODO() is used. These must be inspected and proper context passing must be added.
@ainar-g ainar-g added this to the v0.106.0 milestone Jan 13, 2021
@ainar-g ainar-g modified the milestones: v0.106.0, v0.105.0 Jan 26, 2021
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 2552 rm context.TODO() instances
f947d6f 
Merge in DNS/adguard-home from 2552-context to master

Closes AdguardTeam#2552.

Squashed commit of the following:

commit 3d1cef3
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Jan 26 19:28:23 2021 +0300

    all: fix docs

commit d08c78c
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Jan 26 19:22:00 2021 +0300

    all: doc changes

commit c2814f4
Merge: 100a1a0 44c7221
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Jan 26 19:12:55 2021 +0300

    Merge branch 'master' into 2552-context

commit 100a1a0
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Jan 26 19:10:03 2021 +0300

    home: imp docs, fix naming

commit 22717ab
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Jan 26 18:14:07 2021 +0300

    home: improve code quality

commit 5c96f77
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Mon Jan 25 20:28:51 2021 +0300

    home: add docs

commit 323fc01
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Mon Jan 25 14:50:11 2021 +0300

    home: rm context.TODO() instances
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
enhancement P4: Low
Projects
None yet
Milestone
v0.105.0
Development

No branches or pull requests
2 participants
@ainar-g @EugeneOne1