Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent response for non-existing domains #2600

Closed
ameshkov opened this issue Jan 25, 2021 · 2 comments
Closed

Inconsistent response for non-existing domains #2600

ameshkov opened this issue Jan 25, 2021 · 2 comments
Assignees
@EugeneOne1
Labels
bug P4: Low
Milestone
v0.105.2

Comments

@ameshkov
Copy link
Member

First (served not from the cache) dig -t a piggies.are.pink @192.168.11.144 has EDNS section in response.
Second, third, etc responses don't have it.

Responses need to be consistent.
@ameshkov ameshkov added this to the v0.106.0 milestone Jan 25, 2021
@ainar-g ainar-g self-assigned this Feb 5, 2021
@ainar-g ainar-g modified the milestones: v0.106.0, v0.105.1 Feb 10, 2021
@ainar-g ainar-g assigned EugeneOne1 and unassigned ainar-g Feb 11, 2021
@EugeneOne1
Copy link
Member

As it said in RFC 6891:

OPT RRs MUST NOT be cached, forwarded, or stored in or loaded from master files.

It seems that that issue also goes against the standard.

@ameshkov
Copy link
Member Author

No one says it should be cached. We should respond with our own EDNS extension when it's needed and not just forward what's received from the upstream. I suggest you checking how coredns works in this regard.

@ainar-g ainar-g modified the milestones: v0.105.1, v0.105.2 Feb 15, 2021
adguard pushed a commit to AdguardTeam/dnsproxy that referenced this issue Mar 2, 2021
@EugeneOne1
Pull request: 80 fix EDNS0 bug
3ad5a8c 
Merge in DNS/dnsproxy from 80-edns0 to master

Updates #80.
Updates AdguardTeam/AdGuardHome#2600.

* commit '9c4f5f82bf792887f81443942f77bf2ac507f6c5':
  proxy: imp code
  proxy: fix logic inaccuracy
  proxy: imp logic
  proxy: imp code, docs
  proxy: imp EDNS0 logic
  proxy: fix cached EDNS0 bug
@adguard adguard closed this as completed in a234b63 Mar 3, 2021
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 2600 inconsistent response
8874af4 
Merge in DNS/adguard-home from 2600-upd-dnsproxy to master

Closes AdguardTeam#2600.

Squashed commit of the following:

commit 4b15153
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Mar 2 18:39:19 2021 +0300

    all: upd dnsproxy again, log changes

commit 8a86620
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Mar 2 14:53:48 2021 +0300

    all: cleanup

commit ae81234
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Mar 2 14:49:28 2021 +0300

    all: fix deps

commit 662384c
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Mar 2 13:58:26 2021 +0300

    all: upd dnsproxy version, fix functions' signatures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
bug P4: Low
Projects
None yet
Milestone
v0.105.2
Development

No branches or pull requests
3 participants
@ainar-g @ameshkov @EugeneOne1