Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ipset tests and docs on Linux #2611

Closed
ainar-g opened this issue Jan 29, 2021 · 0 comments
Closed

Improve ipset tests and docs on Linux #2611

ainar-g opened this issue Jan 29, 2021 · 0 comments
Assignees
@ainar-g
Labels
enhancement P3: Medium
Milestone
v0.107.0

Comments

@ainar-g
Copy link
Contributor

ainar-g commented Jan 29, 2021

In the process of reviewing and rebasing of #2179 for a merge, we didn't merge the integration test due to lack of time to properly review and refactor it. That functionality must be covered with at least some unit tests. And we should also add a document describing how to test it on a real machine.
@ainar-g ainar-g added this to the v0.106.0 milestone Jan 29, 2021
@ainar-g ainar-g self-assigned this Jan 29, 2021
@ainar-g ainar-g modified the milestones: v0.106.0, v0.106.1, v0.106.2 Apr 28, 2021
@ainar-g ainar-g modified the milestones: v0.106.2, v0.106.3 May 6, 2021
@ainar-g ainar-g modified the milestones: v0.106.3, v0.107.0 May 19, 2021
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@ainar-g @heyxkhoa
Pull request: all: imp ipset, add tests
104ae39 
Closes AdguardTeam#2611.

Squashed commit of the following:

commit f725777
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Fri Jun 18 17:32:41 2021 +0300

    dnsforward: imp err msgs

commit ed8d6dd
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Fri Jun 18 17:00:49 2021 +0300

    all: imp ipset code

commit 887b326
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Fri Jun 18 16:09:08 2021 +0300

    dnsforward: imp ipset, add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ainar-g ainar-g

Labels
enhancement P3: Medium
Projects
None yet
Milestone
v0.107.0
Development

No branches or pull requests
1 participant
@ainar-g