Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using api to set ipv6 range unexpectedly affect the ra_slaac_only and ra_allow_slaac settings #2653

Closed
LinaChong opened this issue Feb 8, 2021 · 5 comments
Assignees
Milestone

Comments

@LinaChong
Copy link

LinaChong commented Feb 8, 2021

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • [√] I am running the latest version
  • [√] I checked the documentation and found no answer
  • [√] I checked to make sure that this issue has not already been filed

Issue Details

  • Version of AdGuard Home server:
    v0.105.0-beta.3
  • How did you install AdGuard Home:
    via the install script
  • How did you setup DNS configuration:
    Router
  • If it's a router or IoT, please write device model:
    Nano pi R4S
  • Operating system and version:
    Armbian 21.02.1 Buster with Linux 5.10.12-rockchip64

Expected Behavior

setting ipv6 range doesn't affect the ra_slaac_only and ra_allow_slaac settings

Actual Behavior

Setting unexpectedly affect the ra_slaac_only and ra_allow_slaac settings , making both of them false.

Additional Information

My ISP gives me dynamic prefix, so i need to get my prefix and set the prefix via AdGuard Home api.
I have tried appending "ra_allow_slaac": true to the json, but it was changed to false too.

@ameshkov
Copy link
Member

ameshkov commented Feb 8, 2021

Could you please show how exactly do you use the API?

@LinaChong
Copy link
Author

Could you please show how exactly do you use the API?

I call the api using curl.
curl -u user:pw -H "Content-type: application/json" -X POST http://[::1]/control/dhcp/set_config -d '{"v6":{"range_start":"3::","lease_duration":7200, "ra_allow_slaac": true}}'
the range 3:: is just for testing, the prefix was updated correctly.
I keep only the "v6" key in my request, and it works well. Including other keys making no differences, I tried.

@ainar-g ainar-g self-assigned this Feb 8, 2021
@ainar-g ainar-g added this to the v0.105.1 milestone Feb 8, 2021
@ainar-g
Copy link
Contributor

ainar-g commented Feb 8, 2021

Looks like a real bug to me. Thanks for reporting!

adguard pushed a commit that referenced this issue Feb 11, 2021
Merge in DNS/adguard-home from 2653-ra-slaac to master

Updates #2653.

Squashed commit of the following:

commit f261413
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Feb 11 20:37:13 2021 +0300

    all: doc changes, rm debug

commit 4a8c6e4
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Feb 11 20:11:46 2021 +0300

    dhcpd: do not override ra-slaac settings
@ainar-g
Copy link
Contributor

ainar-g commented Feb 11, 2021

I've just pushed 2eb21ef, which should fix this issue. Could you please update and see if that fix works for you? Thanks!

@ainar-g
Copy link
Contributor

ainar-g commented Feb 15, 2021

I'll close this issue for now. Please feel free to reopen with more details if the issue isn't fixed. Thanks!

@ainar-g ainar-g closed this as completed Feb 15, 2021
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Merge in DNS/adguard-home from 2653-ra-slaac to master

Updates AdguardTeam#2653.

Squashed commit of the following:

commit f261413
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Feb 11 20:37:13 2021 +0300

    all: doc changes, rm debug

commit 4a8c6e4
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Feb 11 20:11:46 2021 +0300

    dhcpd: do not override ra-slaac settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants