Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: control/filtering/set_rules | Failed to read request body #2675

Closed
tom-b1995 opened this issue Feb 13, 2021 · 3 comments
Closed

Error: control/filtering/set_rules | Failed to read request body #2675

tom-b1995 opened this issue Feb 13, 2021 · 3 comments
Assignees
Milestone

Comments

@tom-b1995
Copy link

Issue Details

Hello everyone,

I have installed AdGuard Home on 21 August 2020 on my router Turris Omnia. I have been using it without any issues whatsoever since then. The filtering or blocking worked (and still works) as expected. So, I created my own set of rules in a tab Filters - Custom filtering rules which worked great until yesterday (12.02.2021). When I tried to add an exception and unblock a domain, I received an error message:
Error: control/filtering/set_rules | Failed to read request body: attempted to read more than 65536 bytes | 400

The error prevents me from editing my Custom filtering rules. I cannot add, remove or change anything. When I click on the Apply button after making some change, it returns an error message described as above. The blocking or allowing a certain domain (from my Custom filtering rules) is, however, still fully functional.

The error message appeared right after the new update (v0.105.0). There was no such error before this update. I realize my file could be quite large (907 KB in .txt) and has approximately more than 41 500 lines, but everything worked before the update. The router does not have full storage, it has more than 3 GB of space remaining. The router itself is not overloaded and does not report any issues. I edit the list only via Copy and Paste from a plain .txt file stored in my computer using web interface of AdGuard Home from web browser. Rebooting does not help.

  • Version of AdGuard Home server:
    • Version: v0.105.0
  • How did you install AdGuard Home:
    • I have followed a guide on OpenWrt forum
  • How did you setup DNS configuration:
    • I have installed AdGuard Home and configured it as a DNS server on my main router, Turris Omnia.
  • If it's a router or IoT, please write device model:
  • CPU architecture:
    • Marvell Armada 385, dual-core 1.6 GHz, ARMv7
  • Operating system and version:
    • Firmware Version: OpenWrt omnia 15.05 r47055 / LuCI fd63d5cc7dfc69c640b741dceb80555141a80670 branch (git-19.318.61483-fd63d5c)
      Kernel Version: 4.4.199-a890a5a94ebb621f8f1720c24d12fef1-1

Expected Behavior

I would like to know if this issue could be fixed - So I could edit my custom filters again, if possible.

Actual Behavior

The current error prevents me from editing my Custom filtering rules. I cannot remove a line with a domain or add another one (for both rules - block and unblock). However, the Custom filtering rules are still working - they still allow or block particular domain according to their rules.

Screenshots

Screenshot 2021-02-13 023502
Screenshot 2021-02-13 023625

Additional Information

Unfortunately, I am not a programmer or an IT specialist so I cannot help you much more, without additional help from you. I would be very grateful if someone would have read this message and will try to help me or fix the issue in the next build. Thank you very much for your time and attention.

@HorayNarea
Copy link

The same problem exists for the "disallowed clients" list… I think the allowed http body size should not be so low if you are logged in

adguard pushed a commit that referenced this issue Feb 15, 2021
Merge in DNS/adguard-home from 2675-larger-requests to master

Updates #2675.

Squashed commit of the following:

commit 2b45c9b
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Mon Feb 15 13:38:44 2021 +0300

    home: imp names

commit dad39ae
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Mon Feb 15 13:31:53 2021 +0300

    home: imp large req handling
@ainar-g
Copy link
Contributor

ainar-g commented Feb 15, 2021

Should be fixed as of snapshot aebcd74. Can you please check if our solution fixes the issue for you?

@tom-b1995
Copy link
Author

Should be fixed as of snapshot aebcd74. Can you please check if our solution fixes the issue for you?

Good morning, Mr. Garipov,

Sorry for writing so late, but I confirm the problem was fixed. I updated my AdGuard Home to version v0.105.1 and everything is fully functional again. The list of custom filters can be edited again, no problems so far.
image
image

Thank You and all the developers so much for the fix and your time. I am sorry I could not help you more. I am beginner in programming, so I tried to report this issue at least.
Anyways, have a nice day and wish you good luck with the development of AdGuard!
Best regards,
Tom B.

heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Merge in DNS/adguard-home from 2675-larger-requests to master

Updates AdguardTeam#2675.

Squashed commit of the following:

commit 2b45c9b
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Mon Feb 15 13:38:44 2021 +0300

    home: imp names

commit dad39ae
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Mon Feb 15 13:31:53 2021 +0300

    home: imp large req handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants