Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-populate hostnames of DHCP clients #2723

Closed
3 tasks done
agneevX opened this issue Feb 22, 2021 · 8 comments
Closed
3 tasks done

Auto-populate hostnames of DHCP clients #2723

agneevX opened this issue Feb 22, 2021 · 8 comments
Assignees
@EugeneOne1
Labels
feature request P3: Medium
Milestone
v0.106.0

Comments

@agneevX
Copy link
Contributor

agneevX commented Feb 22, 2021

Prerequisites

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Problem Description

Currently, it's a hassle to manage DHCP leases... because I don't know the hostnames for all clients.

The hostname column is empty as a result. Would be nice if AdGuardHome is able to query the hostnames of connected clients and fill the field automatically.

Proposed Solution

Auto detect connected devices' hostnames.

Alternatives Considered

N/A

Additional Information

N/A
@ameshkov
Copy link
Member

AdGuard Home works as a DHCP server in your case, right?

We could auto-generate something like 192-168-0-155.lan for instance.

@agneevX
Copy link
Contributor Author

agneevX commented Feb 23, 2021

Yes, I'm running AGH as the DHCP server as its the only way to get per-device stats.

What I meant is the actual hostname of the device... in case one is not available, then a generated-based-on-IP hostname can be assigned (or both could exist!)

Also .lan, can that be customized? AFAIK my Orbi router does not support DHCP domain names so would be nice if AGH could help here.

@ameshkov
Copy link
Member

Also .lan, can that be customized?

Not in the current version, but we have a task about that already.

@ameshkov
Copy link
Member

@ainar-g what do you think about this one? Looks trivial, can we do it alongside #2393 ?

@ainar-g
Copy link
Contributor

ainar-g commented Feb 24, 2021

@ameshkov, perhaps, although I'm going to need more research into the current code to understand, how intrusive the change will be. Will set to v0.106.0 for now, and we'll see how it goes.

@ainar-g ainar-g self-assigned this Feb 24, 2021
@ainar-g ainar-g added this to the v0.106.0 milestone Feb 24, 2021
@ameshkov ameshkov assigned EugeneOne1 and unassigned ainar-g Mar 15, 2021
adguard pushed a commit that referenced this issue Apr 15, 2021
@EugeneOne1
Pull request: 2723 autogenerate hostnames
b001306 
Merge in DNS/adguard-home from 2723-dhcp-hostnames to master

Updates #2723.

Squashed commit of the following:

commit f9b9d22
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Thu Apr 15 16:47:31 2021 +0300

    aghnet: fix test

commit a2845d1
Merge: 74e450c 0bcea34
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Thu Apr 15 16:45:59 2021 +0300

    Merge branch 'master' into 2723-dhcp-hostnames

commit 74e450c
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Thu Apr 15 16:44:08 2021 +0300

    all: imp code, docs

commit 77cdb12
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Thu Apr 15 14:29:40 2021 +0300

    all: add gen func, use it
@EugeneOne1
Copy link
Member

Hello, @agneevX! The feature should be available as of snapshot a1450c5. Could you please check if there are any unassigned hostnames left?

@agneevX
Copy link
Contributor Author

agneevX commented Apr 15, 2021

Hi! Sorry, until this makes it to a stable release, I won't be able to test.

@EugeneOne1
Copy link
Member

I see, we'll close the issue for now. Please, feel free to reopen it if our solution won't work properly for you.

heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 2723 autogenerate hostnames
03c9295 
Merge in DNS/adguard-home from 2723-dhcp-hostnames to master

Updates AdguardTeam#2723.

Squashed commit of the following:

commit f9b9d22
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Thu Apr 15 16:47:31 2021 +0300

    aghnet: fix test

commit a2845d1
Merge: 74e450c 0bcea34
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Thu Apr 15 16:45:59 2021 +0300

    Merge branch 'master' into 2723-dhcp-hostnames

commit 74e450c
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Thu Apr 15 16:44:08 2021 +0300

    all: imp code, docs

commit 77cdb12
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Thu Apr 15 14:29:40 2021 +0300

    all: add gen func, use it
@HrKnuddel HrKnuddel mentioned this issue Oct 6, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
feature request P3: Medium
Projects
None yet
Milestone
v0.106.0
Development

No branches or pull requests
4 participants
@ainar-g @ameshkov @agneevX @EugeneOne1