Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't assume MAC-addresses of 6 bytes #2828

Closed
ainar-g opened this issue Mar 16, 2021 · 0 comments
Closed

Don't assume MAC-addresses of 6 bytes #2828

ainar-g opened this issue Mar 16, 2021 · 0 comments
Assignees
@ainar-g
Labels
bug P3: Medium
Milestone
v0.106.0

Comments

@ainar-g
Copy link
Contributor

ainar-g commented Mar 16, 2021

There are a few places in the code where we assume that the size of a MAC-address is exactly six bytes. That may not be correct in some places, as the newer EUI-64 kind can be eight bytes long. I'm not sure if we ever encounter the 20-octet InfiniBand ones, but either way we need to inspect the code and make sure that we handle that stuff gracefully.
@ainar-g ainar-g added this to the v0.106.0 milestone Mar 16, 2021
@ainar-g ainar-g self-assigned this Mar 16, 2021
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@ainar-g @heyxkhoa
Pull request: dhcpd: do not assume mac addrs of 6 bytes
4a79077 
Closes AdguardTeam#2828.

Squashed commit of the following:

commit 26c6cf8
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Mar 30 17:43:53 2021 +0300

    dhcpd: do not assume mac addrs of 6 bytes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ainar-g ainar-g

Labels
bug P3: Medium
Projects
None yet
Milestone
v0.106.0
Development

No branches or pull requests
1 participant
@ainar-g