Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Since 5d0d32b, AdGuardHome replaces 0.0.0.0 with 127.0.0.1 #2868

Closed
ainar-g opened this issue Mar 24, 2021 · 1 comment
Closed

Since 5d0d32b, AdGuardHome replaces 0.0.0.0 with 127.0.0.1 #2868

ainar-g opened this issue Mar 24, 2021 · 1 comment
Assignees
@ainar-g
Labels
bug P2: High
Milestone
v0.106.0

Comments

@ainar-g
Copy link
Contributor

ainar-g commented Mar 24, 2021

During the implementation of #1401 we've introduced a bug which turns the host 0.0.0.0 into 127.0.0.1. Needs to be fixed ASAP.
@ainar-g ainar-g added this to the v0.106.0 milestone Mar 24, 2021
@ainar-g ainar-g self-assigned this Mar 24, 2021
@ainar-g
Copy link
Contributor Author

ainar-g commented Mar 24, 2021

This is fixed as of snapshot e10a3fa.

Unfortunately, everyone who was affected by this issue will need to manually change the bind host back to 0.0.0.0, because we obviously can't just replace all 127.0.0.1s with 0.0.0.0s, since that would make a lot of private installations public. Apologies to all.

@ainar-g ainar-g mentioned this issue Mar 24, 2021
Closed
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@ainar-g @heyxkhoa
Pull request: home: fix dns address fallback
455c11d 
Closes AdguardTeam#2868.

Squashed commit of the following:

commit 7497b0d
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Mar 24 14:23:41 2021 +0300

    home: fix specified ip collecting

commit 7b1dfa6
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Mar 24 14:01:25 2021 +0300

    home: fix dns address fallback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ainar-g ainar-g

Labels
bug P2: High
Projects
None yet
Milestone
v0.106.0
Development

No branches or pull requests
1 participant
@ainar-g