Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client-based filtering settings do not work when filtering is turned off in the general settings #2875

Closed
3 tasks done
ZeroClover opened this issue Mar 25, 2021 · 13 comments
Closed
3 tasks done

Client-based filtering settings do not work when filtering is turned off in the general settings #2875

ZeroClover opened this issue Mar 25, 2021 · 13 comments
Assignees
@EugeneOne1
Labels
bug P3: Medium
Milestone
v0.107.0

Comments

@ZeroClover
Copy link

Prerequisites

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Issue Details

  • Version of AdGuard Home server:
    v0.105.2
  • How did you install AdGuard Home:
    Snapcraft
  • How did you setup DNS configuration:
    Dedicated server
  • CPU architecture:
    AMD64
  • Operating system and version:
    Debian 10

I set up a new instance of AGH and want to disable filtering by default and enable it only for specific clients.

I disabled Filter in the general settings of AGH, then added a client with the name ADfilter and set the Identifier to adfilter and enabled filtering for this client.

Screenshot:

image

image

After that, I tried DNS queries through DoH (https://example.com/dns-query/adfilter) and DoT (tls://adfilter.example.com), and the ad domain resolves normally and is not filtered.

Screenshot:

image
@ainar-g
Copy link
Contributor

ainar-g commented Mar 25, 2021

Thanks for the report. As far as I know, it “works as intended”, although I personally am not sure if that's what we want to go on doing. @ameshkov, what would you say?

@ameshkov
Copy link
Member

@ainar-g actually, this looks like a bug to me.

@ZeroClover
Copy link
Author

@ainar-g actually, this looks like a bug to me.

Does this mean that client-level filtering should remain in effect when global filtering settings are turned off?

Will AdGuard fix this?

Thanks.

@ainar-g ainar-g added bug needs investigation Needs to be reproduced reliably. P3: Medium labels Mar 29, 2021
@ainar-g ainar-g added this to the v0.106.0 milestone Mar 29, 2021
@ainar-g
Copy link
Contributor

ainar-g commented Mar 29, 2021

@ameshkov, I've seen the code that does this, so I just assumed that that was the correct behaviour. If it is a bug, I'll see if I can fix it in the current cycle.

@ainar-g ainar-g self-assigned this Mar 29, 2021
@ameshkov
Copy link
Member

@ainar-g well, note that I am talking about the global setting (settings -> general -> block domains using filters), not the "Disable/enable protection" button on the main screen.

@noyyyy
Copy link

noyyyy commented Apr 10, 2021

I have faced the same issue and hope it to be fixed

@ainar-g ainar-g modified the milestones: v0.106.0, v0.106.1, v0.106.2 Apr 28, 2021
@ainar-g ainar-g modified the milestones: v0.106.2, v0.106.3 May 6, 2021
@EugeneOne1 EugeneOne1 assigned EugeneOne1 and unassigned ainar-g May 12, 2021
adguard pushed a commit that referenced this issue May 12, 2021
@EugeneOne1
Pull request: 2875 client settings
29d847c 
Merge in DNS/adguard-home from 2875-client-settings to master

Updates #2875.

Squashed commit of the following:

commit 43e5af6
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Wed May 12 18:12:03 2021 +0300

    all: fix client settings applying
@EugeneOne1 EugeneOne1 removed the needs investigation Needs to be reproduced reliably. label May 13, 2021
@EugeneOne1
Copy link
Member

Hello, @ZeroClover. The snapshot that should fix this issue have been published to the edge channel. Could please check, if our solution works for you?

@EugeneOne1
Copy link
Member

We'll close this issue for now. Please, feel free to reopen it, if the problem remains.

adguard pushed a commit that referenced this issue May 19, 2021
@EugeneOne1 @ainar-g
cherry-pick: 2875 client settings
3953ca5 
Merge in DNS/adguard-home from 2875-client-settings to master

Updates #2875.

Squashed commit of the following:

commit 43e5af6
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Wed May 12 18:12:03 2021 +0300

    all: fix client settings applying
@ZeroClover
Copy link
Author

ZeroClover commented May 20, 2021 •
edited
Loading

@EugeneOne1 There seems to be a new problem.

After upgrading to v0.106.3, even if "Block domains using filters" is turned off in the global settings, it will still block domains using filters without matching any client rules.

I have tried this on multiple instances of my AGH and restarted AGH before each attempt. And tested with an older version of Docker image, and indeed this issue occurs and only occurs on version 0.106.3.

@EugeneOne1
Copy link
Member

Hello, @ZeroClover. It seems that the bug is related to the original issue. Thanks for reporting, we're going to reopen it.

@EugeneOne1 EugeneOne1 reopened this May 21, 2021
@EugeneOne1 EugeneOne1 modified the milestones: v0.106.3, v0.107.0 May 21, 2021
adguard pushed a commit that referenced this issue May 24, 2021
@EugeneOne1
Pull request: 2875 fix client filtering settings
1425082 
Merge in DNS/adguard-home from 2875-client-filtering to master

Updates #2875.

Squashed commit of the following:

commit b3b9582
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Mon May 24 14:22:29 2021 +0300

    all: use atomic, log changes

commit 9304d8b
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Mon May 24 13:43:22 2021 +0300

    all: fix client filtering settings
@EugeneOne1
Copy link
Member

Hello again, @ZeroClover. The latest edge builds are already contain our solution. Could you please try it and check if the problem is gone?

@ZeroClover
Copy link
Author

Hi @EugeneOne1 , I have tested on v0.107.0-a.45+755a5055 and confirmed that both issues mentioned in this issue had been fixed. Thank you for your prompt handling.

@EugeneOne1
Copy link
Member

Thank you for testing. We'll close the issue for now.

heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 2875 client settings
c78e406 
Merge in DNS/adguard-home from 2875-client-settings to master

Updates AdguardTeam#2875.

Squashed commit of the following:

commit 43e5af6
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Wed May 12 18:12:03 2021 +0300

    all: fix client settings applying
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 2875 fix client filtering settings
fa3c7d0 
Merge in DNS/adguard-home from 2875-client-filtering to master

Updates AdguardTeam#2875.

Squashed commit of the following:

commit b3b9582
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Mon May 24 14:22:29 2021 +0300

    all: use atomic, log changes

commit 9304d8b
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Mon May 24 13:43:22 2021 +0300

    all: fix client filtering settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
bug P3: Medium
Projects
None yet
Milestone
v0.107.0
Development

No branches or pull requests
5 participants
@ainar-g @ameshkov @ZeroClover @EugeneOne1 @noyyyy