Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Download configuration file" for Apple doesn't use relative URLs #2905

Closed
3 tasks done
MattElek opened this issue Apr 1, 2021 · 3 comments
Closed
3 tasks done

"Download configuration file" for Apple doesn't use relative URLs #2905

MattElek opened this issue Apr 1, 2021 · 3 comments

Comments

@MattElek
Copy link

MattElek commented Apr 1, 2021

Prerequisites

Please answer the following questions for yourself before submitting an issue.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Issue Details

  • Version of AdGuard Home server:
    • AdGuard Home, version v0.105.2, channel release
  • How did you install AdGuard Home:
    • OPNsense mimugmail community repository
  • How did you setup DNS configuration:
    • Router DNS
  • If it's a router or IoT, please write device model:
    • OPNsense router running on Asus netbook
  • CPU architecture:
    • arch freebsd amd64
  • Operating system and version:
    • FreeBSD 12.1-RELEASE-p15-HBSD amd64

AdGuard Home, version v0.105.2, channel release, arch freebsd amd64

Expected Behavior

When using AdGuard Home behind a reverse proxy with a custom URL, like defined in the docs, downloading an Apple DNS .mobileconfig file should use relative URLs like everything else already does.

Actual Behavior

The download configuration button uses an absolute URL, for example https://192.168.1.1/apple/doh.mobileconfig?host=xyz, instead of using a relative URL, such as https://192.168.1.1/adguardhome/apple/doh.mobileconfig?host=xyz.

@ainar-g ainar-g self-assigned this Apr 1, 2021
@ainar-g ainar-g added this to the v0.106.0 milestone Apr 1, 2021
adguard pushed a commit that referenced this issue Apr 2, 2021
Updates #2905.

Squashed commit of the following:

commit af60743
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Apr 1 19:33:35 2021 +0300

    client: use relative links for mobileconfig api
@ainar-g
Copy link
Contributor

ainar-g commented Apr 2, 2021

Should be fixed on the edge channel as of snapshot 23c9f52. Can you please check if our solution fixes the issue for you?

@ainar-g
Copy link
Contributor

ainar-g commented Apr 6, 2021

I'll close this issue for now. Please feel free to reopen with more details if you think that something should be fixed.

@ainar-g ainar-g closed this as completed Apr 6, 2021
@MattElek
Copy link
Author

MattElek commented Apr 6, 2021

Sorry for the delayed response. I installed the latest edge channel build, and the issue is now fixed! Thanks!

heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Updates AdguardTeam#2905.

Squashed commit of the following:

commit af60743
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Apr 1 19:33:35 2021 +0300

    client: use relative links for mobileconfig api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants