-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPv4 DHCP attribution issue with WiFi SmartPlug #2978
Comments
Hi, and thank you for the report. Apparently, #2952 will need to be bumped into the current release cycle. We'll try to make this work in one of the nearest betas. |
Updates #2952. Updates #2978. Squashed commit of the following: commit 20e379b Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Mon Apr 19 15:58:37 2021 +0300 all: imp naming commit ed300e0 Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Mon Apr 19 15:43:09 2021 +0300 all: imp dhcp client hostname normalization
@Black8all, we've published beta 3 recently, and in it your devices' hostnames should get normalised into something like |
I tried to update to the latest beta and I have this error in my log file
2021/04/21 15:00:28 [fatal] undexpected type of dns.autohost_tld: <nil>
2021/04/21 15:01:53 [info] AdGuard Home, version v0.106.0-b.3
2021/04/21 15:01:53 [info] Upgrade yaml: 7 to 8
2021/04/21 15:01:53 [info] Upgrade yaml: 8 to 9
And I can't start AdGuard again.
Le lun. 19 avr. 2021 à 17:31, Ainar Garipov ***@***.***> a
écrit :
… @Black8all <https://github.com/Black8all>, we've published beta 3
recently, and in it your devices' hostnames should get normalised into
something like esp-123456. Could you please update and check if the bug
is fixed in that new release? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2978 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQCRROV5MPODTN3XBNTPVLLTJREDTANCNFSM43FTKDWQ>
.
|
@Black8all, hi, we've released beta 4 recently that addresses the issue. It was reported previously in #2988. Can you check if that new releases fixes the issue? |
Still have the same error when I updated to the new version v0.106.0-b.4
2021/04/21 17:47:19 [info] Restarting: [./AdGuardHome]
2021/04/21 17:47:19 [info] AdGuard Home, version v0.106.0-b.4
2021/04/21 17:47:19 [info] Upgrade yaml: 7 to 8
2021/04/21 17:47:19 [info] Upgrade yaml: 8 to 9
2021/04/21 17:47:19 [info] Upgrade yaml: 9 to 10
2021/04/21 17:47:20 [error] dhcpv4: reset: re-adding a lease for
192.168.1.7 (48:3f:da:51:56:9c): validating lease: validating hostname:
invalid domain name label at index 0: invalid char '_' at index 3 in
"ESP_51569C"
2021/04/21 17:47:20 [error] dhcpv4: reset: re-adding a lease for
192.168.1.11 (c8:2b:96:c5:76:d5): validating lease: validating hostname:
invalid domain name label at index 0: invalid char '_' at index 3 in
"ESP_C576D5"
2021/04/21 17:47:20 [error] dhcpv4: reset: re-adding a lease for
192.168.1.12 (48:3f:da:52:64:21): validating lease: validating hostname:
invalid domain name label at index 0: invalid char '_' at index 3 in
"ESP_526421"
2021/04/21 17:47:20 [error] dhcpv4: reset: re-adding a lease for
192.168.1.13 (68:c6:3a:83:9f:ac): validating lease: validating hostname:
invalid domain name label at index 0: invalid char '_' at index 3 in
"ESP_839FAC"
2021/04/21 17:47:20 [error] dhcpv4: reset: re-adding a lease for
192.168.1.20 (54:60:09:fd:ca:94): validating lease: validating hostname:
hostname exists
2021/04/21 17:47:20 [error] dhcpv4: reset: re-adding a lease for
192.168.1.24 (44:07:0b:e6:dc:e5): validating lease: validating hostname:
hostname exists
2021/04/21 17:47:20 [error] dhcpv4: reset: re-adding a lease for
192.168.1.28 (54:60:09:fd:b7:40): validating lease: validating hostname:
hostname exists
2021/04/21 17:47:20 [error] dhcpv4: reset: re-adding a lease for
192.168.1.9 (48:3f:da:52:63:55): validating lease: validating hostname:
invalid domain name label at index 0: invalid char '_' at index 3 in
"ESP_526355"
2021/04/21 17:47:20 [error] dhcpv4: reset: re-adding a lease for
192.168.1.18 (48:3f:da:52:5e:d8): validating lease: validating hostname:
invalid domain name label at index 0: invalid char '_' at index 3 in
"ESP_525ED8"
2021/04/21 17:47:20 [info] dhcp: loaded leases v4:22 v6:0 total-read:22
from DB
Le mer. 21 avr. 2021 à 16:38, Ainar Garipov ***@***.***> a
écrit :
… @Black8all <https://github.com/Black8all>, hi, we've released beta 4
recently that addresses the issue. It was reported previously in #2988
<#2988>. Can you check
if that new releases fixes the issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2978 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQCRROVPBRD26SYYRDZMRB3TJ3PM5ANCNFSM43FTKDWQ>
.
|
@Black8all, this looks like messages from the code that loads leases from the filesystem. When the clients come for leases again, you should see them getting a dynamic lease with a valid hostname with no issues. |
Ok, is there any way to delete the leases in the .db before they expire?
Le mer. 21 avr. 2021 à 17:55, Ainar Garipov ***@***.***> a
écrit :
… @Black8all <https://github.com/Black8all>, this looks like messages from
the code that loads leases from the filesystem. When the clients come for
leases again, you should see them getting a dynamic lease with a valid
hostname with no issues.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2978 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQCRROUZM6PEOKEPK63XD7LTJ3YO5ANCNFSM43FTKDWQ>
.
|
@Black8all, it's technically unnecessary, as the new data should eventually overwrite the old one. If you do want to delete them, they are stored in the file |
We're going to close this issue for now. Feel free to open new ones if you have any problems! |
Hi, after few test, I have some trouble again with the DHCP. Some of my devices can't obtain an IP and I need to set a static lease if I want it to work. I also encounter some of disconnection with few other. In the end, my log file are flooded by message about normalisation error. I run now the 1.0.6.1 b1 Best regards |
Updates AdguardTeam#2952. Updates AdguardTeam#2978. Squashed commit of the following: commit 20e379b Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Mon Apr 19 15:58:37 2021 +0300 all: imp naming commit ed300e0 Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Mon Apr 19 15:43:09 2021 +0300 all: imp dhcp client hostname normalization
Expected Behavior
IPv4 attribution to my WiFi Smartplugs
Actual Behavior
Since the last update (v0.106.0-b.2), my WiFi smartplugs can't obtain an IPv4 from the AdGuard DHCP.
Screenshots
2021/04/19 09:11:12 [error] dhcpv4: cannot normalize hostname for 48:3f:da:51:56:9c: validating non-normalized hostname: invalid domain name label at index 0: invalid char '' at index 3 in "ESP_51569C"
2021/04/19 09:11:12 [error] dhcpv4: cannot normalize hostname for 48:3f:da:52:63:55: validating non-normalized hostname: invalid domain name label at index 0: invalid char '' at index 3 in "ESP_526355"
2021/04/19 09:11:12 [error] dhcpv4: cannot normalize hostname for 48:3f:da:52:64:21: validating non-normalized hostname: invalid domain name label at index 0: invalid char '' at index 3 in "ESP_526421"
2021/04/19 09:11:12 [error] dhcpv4: cannot normalize hostname for 68:c6:3a:83:9f:ac: validating non-normalized hostname: invalid domain name label at index 0: invalid char '' at index 3 in "ESP_839FAC"
2021/04/19 09:11:12 [error] dhcpv4: cannot normalize hostname for c8:2b:96:c5:76:d5: validating non-normalized hostname: invalid domain name label at index 0: invalid char '_' at index 3 in "ESP_C576D5"
Here's a sample of the loop in the log file.
Additional Information
I tried to rollback to the previous version, (v0.105.2-beta.1) and all works again.
The text was updated successfully, but these errors were encountered: