Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv4 DHCP attribution issue with WiFi SmartPlug #2978

Closed
Black8all opened this issue Apr 19, 2021 · 10 comments
Closed

IPv4 DHCP attribution issue with WiFi SmartPlug #2978

Black8all opened this issue Apr 19, 2021 · 10 comments
Assignees
Milestone

Comments

@Black8all
Copy link

  • Version of AdGuard Home server:
    • (v0.106.0-b.2)
  • How did you install AdGuard Home:
    • From GitHup source on DSM 6.2.4-25556
  • How did you setup DNS configuration:
    • I have a LiveBox 4 so I can't change the DNS conf on it and I use AdGuard DHCP instead.
  • CPU architecture:
    • Realtek RTD1296 SoC ARM64
  • Operating system and version:
    • DSM 6.2.4-25556 (NAS Synology)

Expected Behavior

IPv4 attribution to my WiFi Smartplugs

Actual Behavior

Since the last update (v0.106.0-b.2), my WiFi smartplugs can't obtain an IPv4 from the AdGuard DHCP.

Screenshots

2021/04/19 09:11:12 [error] dhcpv4: cannot normalize hostname for 48:3f:da:51:56:9c: validating non-normalized hostname: invalid domain name label at index 0: invalid char '' at index 3 in "ESP_51569C"
2021/04/19 09:11:12 [error] dhcpv4: cannot normalize hostname for 48:3f:da:52:63:55: validating non-normalized hostname: invalid domain name label at index 0: invalid char '
' at index 3 in "ESP_526355"
2021/04/19 09:11:12 [error] dhcpv4: cannot normalize hostname for 48:3f:da:52:64:21: validating non-normalized hostname: invalid domain name label at index 0: invalid char '' at index 3 in "ESP_526421"
2021/04/19 09:11:12 [error] dhcpv4: cannot normalize hostname for 68:c6:3a:83:9f:ac: validating non-normalized hostname: invalid domain name label at index 0: invalid char '
' at index 3 in "ESP_839FAC"
2021/04/19 09:11:12 [error] dhcpv4: cannot normalize hostname for c8:2b:96:c5:76:d5: validating non-normalized hostname: invalid domain name label at index 0: invalid char '_' at index 3 in "ESP_C576D5"

Here's a sample of the loop in the log file.

notepad_J9I9hzCwMG

Additional Information

I tried to rollback to the previous version, (v0.105.2-beta.1) and all works again.

@ainar-g
Copy link
Contributor

ainar-g commented Apr 19, 2021

Hi, and thank you for the report. Apparently, #2952 will need to be bumped into the current release cycle. We'll try to make this work in one of the nearest betas.

@ainar-g ainar-g self-assigned this Apr 19, 2021
@ainar-g ainar-g added this to the v0.106.0 milestone Apr 19, 2021
adguard pushed a commit that referenced this issue Apr 19, 2021
Updates #2952.
Updates #2978.

Squashed commit of the following:

commit 20e379b
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Mon Apr 19 15:58:37 2021 +0300

    all: imp naming

commit ed300e0
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Mon Apr 19 15:43:09 2021 +0300

    all: imp dhcp client hostname normalization
@ainar-g
Copy link
Contributor

ainar-g commented Apr 19, 2021

@Black8all, we've published beta 3 recently, and in it your devices' hostnames should get normalised into something like esp-123456. Could you please update and check if the bug is fixed in that new release? Thanks!

@Black8all
Copy link
Author

Black8all commented Apr 21, 2021 via email

@ainar-g
Copy link
Contributor

ainar-g commented Apr 21, 2021

@Black8all, hi, we've released beta 4 recently that addresses the issue. It was reported previously in #2988. Can you check if that new releases fixes the issue?

@Black8all
Copy link
Author

Black8all commented Apr 21, 2021 via email

@ainar-g
Copy link
Contributor

ainar-g commented Apr 21, 2021

@Black8all, this looks like messages from the code that loads leases from the filesystem. When the clients come for leases again, you should see them getting a dynamic lease with a valid hostname with no issues.

@Black8all
Copy link
Author

Black8all commented Apr 21, 2021 via email

@ainar-g
Copy link
Contributor

ainar-g commented Apr 21, 2021

@Black8all, it's technically unnecessary, as the new data should eventually overwrite the old one. If you do want to delete them, they are stored in the file leases.db in AGH's working directory. It's a JSON file, and the format is not stable. The leases that have "exp":1 are static, so you probably don't want to delete those.

@ainar-g
Copy link
Contributor

ainar-g commented Apr 26, 2021

We're going to close this issue for now. Feel free to open new ones if you have any problems!

@ainar-g ainar-g closed this as completed Apr 26, 2021
@Black8all
Copy link
Author

Hi, after few test, I have some trouble again with the DHCP. Some of my devices can't obtain an IP and I need to set a static lease if I want it to work.

I also encounter some of disconnection with few other. In the end, my log file are flooded by message about normalisation error.

I run now the 1.0.6.1 b1
Tell me if I need to open a new issue 😉.

Best regards

AdGuard.log

heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Updates AdguardTeam#2952.
Updates AdguardTeam#2978.

Squashed commit of the following:

commit 20e379b
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Mon Apr 19 15:58:37 2021 +0300

    all: imp naming

commit ed300e0
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Mon Apr 19 15:43:09 2021 +0300

    all: imp dhcp client hostname normalization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants