Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to add DHCP leases #3107

Closed
3 tasks done
agneevX opened this issue May 8, 2021 · 6 comments
Closed
3 tasks done

Unable to add DHCP leases #3107

agneevX opened this issue May 8, 2021 · 6 comments
Assignees
Milestone

Comments

@agneevX
Copy link
Contributor

agneevX commented May 8, 2021

Prerequisites

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Issue Details

  • Version of AdGuard Home server: 0.106.2
  • How did you install AdGuard Home: GH Releases/Install script
  • How did you setup DNS configuration: Router/WAN DNS
  • If it's a router or IoT, please write device model: N/A
  • CPU architecture: arm64
  • Operating system and version: Ubuntu 20.04.2

Expected Behavior

DHCP leases would get added.

Actual Behavior

DHCP leases aren't getting added...

image

Additional Information

  • Adding a bogus hostname results in Network error
  • Using Unbound

image

@ameshkov ameshkov added this to the v0.106.3 milestone May 8, 2021
@ameshkov ameshkov added the needs investigation Needs to be reproduced reliably. label May 8, 2021
@ainar-g
Copy link
Contributor

ainar-g commented May 11, 2021

Hello. The domain name is a required parameter. Does the error message go away if you enter a valid domain name?

@ainar-g ainar-g added waiting for data Waiting for users to provide more data. and removed needs investigation Needs to be reproduced reliably. labels May 11, 2021
@agneevX
Copy link
Contributor Author

agneevX commented May 11, 2021

It does not. That results in Network Error.

Why should it be required? Isn't it supposed to auto generate if the device does not have one/AGH can't retrieve one?

@ainar-g ainar-g added bug P3: Medium and removed waiting for data Waiting for users to provide more data. labels May 11, 2021
@ainar-g
Copy link
Contributor

ainar-g commented May 11, 2021

Apparently we have some issues with how hostnames are validated. We'll try to fix this soon.

@EntropySmoke
Copy link

I get the same issue if I try to add Static Leases before enabling DHCP Server and saving configuration. After enabling DHCP Server, adding Static Leases is not a problem.

adguard pushed a commit that referenced this issue May 13, 2021
Updates #3107.
Updates #3127.

Squashed commit of the following:

commit ad64472
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu May 13 14:45:21 2021 +0300

    dhcpd: refactor validations
@ainar-g
Copy link
Contributor

ainar-g commented May 13, 2021

This should be fixed on the edge channel as of revision c890f5c. Could you please check if the problem is gone?

@agneevX
Copy link
Contributor Author

agneevX commented May 13, 2021

Sorry, I use stable builds only. I'm closing this issue, thank you.

@agneevX agneevX closed this as completed May 13, 2021
adguard pushed a commit that referenced this issue May 19, 2021
Updates #3107.
Updates #3127.

Squashed commit of the following:

commit ad64472
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu May 13 14:45:21 2021 +0300

    dhcpd: refactor validations
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Updates AdguardTeam#3107.
Updates AdguardTeam#3127.

Squashed commit of the following:

commit ad64472
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu May 13 14:45:21 2021 +0300

    dhcpd: refactor validations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants