Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to block client when configured though clientID #3162

Closed
3 tasks
Final-Hawk opened this issue May 20, 2021 · 3 comments
Closed
3 tasks

Unable to block client when configured though clientID #3162

Final-Hawk opened this issue May 20, 2021 · 3 comments
Assignees
@IldarKamalov @ainar-g
Labels
enhancement P3: Medium UI
Milestone
v0.107.0

Comments

@Final-Hawk
Copy link

Prerequisites

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Issue Details

  • Version of AdGuard Home server:
    v0.106.3
  • How did you install AdGuard Home:
    Raspberry pi install script, not docker
  • How did you setup DNS configuration:
    iOS Profile/router/manual on device
  • CPU architecture:
    armv7l
  • Operating system and version:
    • Raspberry pi OS lite

Expected Behavior

When on the main Adguard screen, under client you can hover over a client and block them. This drops all of their dns requests.

Actual Behavior

When setup via a client ID, the block button does not appear.

Screenshots

Setup via local IP address, block button shows:
image

Setup via client ID for DNS over HTTPS on ios configuration, block button does not show: (i am hovering over it)
image
@ainar-g ainar-g added bug needs investigation Needs to be reproduced reliably. UI labels May 20, 2021
@ainar-g ainar-g added this to the v0.107.0 milestone May 20, 2021
@ainar-g ainar-g added P3: Medium and removed UI labels May 20, 2021
@ainar-g ainar-g assigned ainar-g and unassigned IldarKamalov May 20, 2021
@ainar-g
Copy link
Contributor

ainar-g commented May 21, 2021

Related issue: #2624. It seems like there are several things at play here, so the issue won't be a straightforward one. We'll still try to implement it in the v0.107 cycle though.

@ainar-g ainar-g added enhancement UI and removed bug needs investigation Needs to be reproduced reliably. labels Jun 22, 2021
adguard pushed a commit to AdguardTeam/dnsproxy that referenced this issue Jun 24, 2021
@ainar-g
Pull request: all: add requestid, refactor
56f8b0f 
Updates AdguardTeam/AdGuardHome#2624.
Updates AdguardTeam/AdGuardHome#3162.

Squashed commit of the following:

commit 62e9cf4
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Jun 23 15:15:36 2021 +0300

    all: fix go1.15 compat

commit 096b0d8
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Jun 23 15:10:53 2021 +0300

    all: add requestid, refactor
adguard pushed a commit that referenced this issue Jun 29, 2021
@ainar-g
Pull request: all: allow clientid in access settings
e08a64e 
Updates #2624.
Updates #3162.

Squashed commit of the following:

commit 68860da
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Jun 29 15:41:33 2021 +0300

    all: imp types, names

commit ebd4ec2
Merge: 239eb72 16e5e09
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Jun 29 15:14:33 2021 +0300

    Merge branch 'master' into 2624-clientid-access

commit 239eb72
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Jun 29 15:13:10 2021 +0300

    all: fix client blocking check

commit e6bece3
Merge: 9935f2a 9d1656b
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Jun 29 13:12:28 2021 +0300

    Merge branch 'master' into 2624-clientid-access

commit 9935f2a
Author: Ildar Kamalov <ik@adguard.com>
Date:   Tue Jun 29 11:26:51 2021 +0300

    client: show block button for client id

commit ed786a6
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Fri Jun 25 15:56:23 2021 +0300

    client: imp i18n

commit 4fed21c
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Fri Jun 25 15:34:09 2021 +0300

    all: imp i18n, docs

commit 55e65c0
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Fri Jun 25 13:34:01 2021 +0300

    all: fix cache, imp code, docs, tests

commit c1e5a83
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Jun 24 19:27:12 2021 +0300

    all: allow clientid in access settings
@ainar-g
Copy link
Contributor

ainar-g commented Jun 29, 2021

This feature is implemented on the edge channel as of snapshot e08a64e. Can you please check if it works for you?

@Final-Hawk
Copy link
Author

Awesome. Thanks! Seems to all be working now.

heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@ainar-g @heyxkhoa
Pull request: all: allow clientid in access settings
bb7d6ae 
Updates AdguardTeam#2624.
Updates AdguardTeam#3162.

Squashed commit of the following:

commit 68860da
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Jun 29 15:41:33 2021 +0300

    all: imp types, names

commit ebd4ec2
Merge: 239eb72 16e5e09
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Jun 29 15:14:33 2021 +0300

    Merge branch 'master' into 2624-clientid-access

commit 239eb72
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Jun 29 15:13:10 2021 +0300

    all: fix client blocking check

commit e6bece3
Merge: 9935f2a 9d1656b
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Jun 29 13:12:28 2021 +0300

    Merge branch 'master' into 2624-clientid-access

commit 9935f2a
Author: Ildar Kamalov <ik@adguard.com>
Date:   Tue Jun 29 11:26:51 2021 +0300

    client: show block button for client id

commit ed786a6
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Fri Jun 25 15:56:23 2021 +0300

    client: imp i18n

commit 4fed21c
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Fri Jun 25 15:34:09 2021 +0300

    all: imp i18n, docs

commit 55e65c0
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Fri Jun 25 13:34:01 2021 +0300

    all: fix cache, imp code, docs, tests

commit c1e5a83
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Jun 24 19:27:12 2021 +0300

    all: allow clientid in access settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IldarKamalov IldarKamalov

@ainar-g ainar-g

Labels
enhancement P3: Medium UI
Projects
None yet
Milestone
v0.107.0
Development

No branches or pull requests
3 participants
@IldarKamalov @ainar-g @Final-Hawk