Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Per-client upstream not working if identify by DOH #3186

Closed
moolex opened this issue May 25, 2021 · 3 comments
Closed

Per-client upstream not working if identify by DOH #3186

moolex opened this issue May 25, 2021 · 3 comments
Assignees
@ainar-g
Labels
bug P2: High
Milestone
v0.107.0

Comments

@moolex
Copy link

moolex commented May 25, 2021

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • [y] I am running the latest version
  • [y] I checked the documentation and found no answer
  • [y] I checked to make sure that this issue has not already been filed

Issue Details

  • Version of AdGuard Home server:
    • v0.106.3
  • How did you install AdGuard Home:
    • Docker
  • How did you setup DNS configuration:
    • Router
  • If it's a router or IoT, please write device model:
    • RouterOS
  • CPU architecture:
    • AMD64
  • Operating system and version:
    • RancherOS

Expected Behavior

Per client upstream should works by identify (IP address or special clientID from DOH)

Actual Behavior

Per client upstream not working if identify by DOH clientID (but works with IP address)
@ainar-g ainar-g self-assigned this May 25, 2021
@ainar-g ainar-g added needs investigation Needs to be reproduced reliably. bug P2: High and removed needs investigation Needs to be reproduced reliably. labels May 25, 2021
@ainar-g ainar-g added this to the v0.107.0 milestone May 27, 2021
@ainar-g
Copy link
Contributor

ainar-g commented May 27, 2021

Thanks for the report! We'll try to fix it in the next few days.

adguard pushed a commit that referenced this issue May 28, 2021
@ainar-g
Pull request: all: fix client upstreams, imp code
3be783b 
Updates #3186.

Squashed commit of the following:

commit a8dd0e2
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Fri May 28 12:54:07 2021 +0300

    all: imp code, names

commit 98f86c2
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu May 27 21:11:37 2021 +0300

    all: fix client upstreams, imp code
@ainar-g
Copy link
Contributor

ainar-g commented May 28, 2021

@moolex, this should be fixed as of edge snapshot 3be783b. Can you please check if upstreams are now selected properly? Thanks!

@moolex
Copy link
Author

moolex commented Jun 2, 2021

@moolex, this should be fixed as of edge snapshot 3be783b. Can you please check if upstreams are now selected properly? Thanks!

Sorry for late response, I can make sure it works as expect, Thanks!

@ainar-g ainar-g closed this as completed Jun 2, 2021
@ainar-g ainar-g mentioned this issue Jun 29, 2021
Closed
@ainar-g ainar-g mentioned this issue Nov 24, 2021
Closed
3 tasks
@ainar-g ainar-g mentioned this issue Dec 24, 2021
Open
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@ainar-g @heyxkhoa
Pull request: all: fix client upstreams, imp code
0066e24 
Updates AdguardTeam#3186.

Squashed commit of the following:

commit a8dd0e2
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Fri May 28 12:54:07 2021 +0300

    all: imp code, names

commit 98f86c2
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu May 27 21:11:37 2021 +0300

    all: fix client upstreams, imp code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ainar-g ainar-g

Labels
bug P2: High
Projects
None yet
Milestone
v0.107.0
Development

No branches or pull requests
2 participants
@moolex @ainar-g