Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect permissions assigned to filters.txt files #3198

Closed
gabrielwhite opened this issue May 27, 2021 · 4 comments
Closed

Incorrect permissions assigned to filters.txt files #3198

gabrielwhite opened this issue May 27, 2021 · 4 comments
Assignees
Milestone

Comments

@gabrielwhite
Copy link

Issue Details

  • Version of AdGuard Home server:
    v0.106.3

  • How did you install AdGuard Home:
    Docker

  • CPU architecture:
    ARM64

  • Operating system and version:
    Armbian 21.05.2 Buster with Linux 5.10.34-meson64

Expected Behavior

I would expect the nnnnnnnnn.txt files created in work/data/filters to have 744 permissions.

Actual Behavior

All the files created by adguardhome in conf and work have 744 permissions, EXCEPT for the nnnnnnnnnn.txt files in work/data/filters which are created with 700 permissions.

This causes problems for my backup program as it can't read the files.

@ainar-g ainar-g self-assigned this May 28, 2021
@ainar-g ainar-g added needs investigation Needs to be reproduced reliably. bug P3: Medium and removed needs investigation Needs to be reproduced reliably. labels May 28, 2021
@ainar-g ainar-g added this to the v0.107.0 milestone May 28, 2021
@ainar-g
Copy link
Contributor

ainar-g commented May 28, 2021

Thanks for the report. There are a few places where permissions are a bit weird. We'll inspect them and change them if necessary in the next few days.

adguard pushed a commit that referenced this issue May 28, 2021
Updates #3198.

Squashed commit of the following:

commit 3de1ecf
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Fri May 28 18:39:52 2021 +0300

    all: imp chlog

commit f1a46ef
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Fri May 28 18:13:55 2021 +0300

    all: rework file perms
@ainar-g
Copy link
Contributor

ainar-g commented May 28, 2021

This should be changed as of edge build f368710. Can you please see if that works for you?

@gabrielwhite
Copy link
Author

Yes, that works. Thanks! For what it's worth it only changes the incorrect old permissions to the new permissions on download of a new ruleset (the rulesets without updates didn't change their permissions). But I guess that's a short term problem in most cases.

@ainar-g
Copy link
Contributor

ainar-g commented May 31, 2021

Yes, they should be overwritten later. We'll close this issue for now, thanks for testing!

@ainar-g ainar-g closed this as completed May 31, 2021
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Updates AdguardTeam#3198.

Squashed commit of the following:

commit 3de1ecf
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Fri May 28 18:39:52 2021 +0300

    all: imp chlog

commit f1a46ef
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Fri May 28 18:13:55 2021 +0300

    all: rework file perms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants