Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abnormal termination #3318

Closed
cunvoas opened this issue Jul 6, 2021 · 5 comments
Closed

Abnormal termination #3318

cunvoas opened this issue Jul 6, 2021 · 5 comments
Assignees
@ainar-g
Labels
bug P2: High
Milestone
v0.107.0

Comments

@cunvoas
Copy link

cunvoas commented Jul 6, 2021

Hello,
With version v0.107.0-b.3

I have many times abnomal termination on ARM Synology DSM7 (native, not docker)

This is the stack trace :

  2021/07/06 13:01:55.363651 [error] dns: bad type <nil> in tableIPToHost for 192.168.1.4
  panic: runtime error: index out of range [0] with length 0
  
  goroutine 16547 [running]:
  github.com/AdguardTeam/dnsproxy/proxy.filterMsg(0x37f4f50, 0x37f4f50, 0x37f0000, 0x0)
          github.com/AdguardTeam/dnsproxy@v0.38.0/proxy/cache.go:260 +0x1ac
  github.com/AdguardTeam/dnsproxy/proxy.(*Proxy).Resolve(0x3224340, 0x332c6c0, 0x0, 0x0)
          github.com/AdguardTeam/dnsproxy@v0.38.0/proxy/proxy.go:480 +0x35c
  github.com/AdguardTeam/AdGuardHome/internal/dnsforward.(*Server).processUpstream(0x322a000, 0x37ac8a0, 0x0)
          github.com/AdguardTeam/AdGuardHome/internal/dnsforward/dns.go:543 +0x68
  github.com/AdguardTeam/AdGuardHome/internal/dnsforward.(*Server).handleDNSRequest(0x322a000, 0x3224340, 0x332c6c0, 0x0, 0x0)
          github.com/AdguardTeam/AdGuardHome/internal/dnsforward/dns.go:102 +0x21c
  github.com/AdguardTeam/dnsproxy/proxy.(*Proxy).handleDNSRequest(0x3224340, 0x332c6c0, 0x3, 0x30b7d60)
          github.com/AdguardTeam/dnsproxy@v0.38.0/proxy/server.go:127 +0x1e4
  github.com/AdguardTeam/dnsproxy/proxy.(*Proxy).udpHandlePacket(0x3224340, 0x33f46c0, 0x90, 0x90, 0x35edeac, 0x4, 0x4, 0x379ac78, 0x308b390)
          github.com/AdguardTeam/dnsproxy@v0.38.0/proxy/server_udp.go:105 +0x194
  github.com/AdguardTeam/dnsproxy/proxy.(*Proxy).udpPacketLoop.func1(0x3224340, 0x33f46c0, 0x90, 0x90, 0x35edeac, 0x4, 0x4, 0x379ac78, 0x308b390, 0x1a9af70, ...)
          github.com/AdguardTeam/dnsproxy@v0.38.0/proxy/server_udp.go:74 +0x5c
  created by github.com/AdguardTeam/dnsproxy/proxy.(*Proxy).udpPacketLoop
          github.com/AdguardTeam/dnsproxy@v0.38.0/proxy/server_udp.go:73 +0x334
@ainar-g ainar-g self-assigned this Jul 6, 2021
@ainar-g ainar-g added this to the v0.107.0 milestone Jul 6, 2021
@ainar-g
Copy link
Contributor

ainar-g commented Jul 6, 2021

Thank you for the report! We'll try to fix asap.

@Disqu3-mirOir-qt
Copy link

2021/07/06 13:01:55.363651 [error] dns: bad type  in tableIPToHost for xxx.xxxx.xxx

i have same things only whith PTR request .arpa

adguard pushed a commit that referenced this issue Jul 6, 2021
@ainar-g
Pull request #1238: dnsforward: fix panic
1571609 
Updates #3318.

Squashed commit of the following:

commit eebaa3a
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Jul 6 14:59:00 2021 +0300

    dnsforward: imp code

commit 7591a3b
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Jul 6 14:55:33 2021 +0300

    dnsforward: fix panic
@ainar-g
Copy link
Contributor

ainar-g commented Jul 6, 2021

This should be fixed on the edge channel as of revision 1571609. Could you please check if that fixes the panic?

@cunvoas
Copy link
Author

cunvoas commented Jul 6, 2021

edge arm7-32 bit deployed ( v0.107.0-a.97+1571609e ) and running since 15 minutes.

After 2 hours usage without panic error, I will repost here an aknowledgement as good job.
Thanks a lot for your reactivity

@cunvoas
Copy link
Author

cunvoas commented Jul 6, 2021

2 hours running without error and 20k queries sended.
This is solved for me.
Thanks

@cunvoas cunvoas closed this as completed Jul 6, 2021
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@ainar-g @heyxkhoa
Pull request AdguardTeam#1238: dnsforward: fix panic
37bcaff 
Updates AdguardTeam#3318.

Squashed commit of the following:

commit eebaa3a
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Jul 6 14:59:00 2021 +0300

    dnsforward: imp code

commit 7591a3b
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Jul 6 14:55:33 2021 +0300

    dnsforward: fix panic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ainar-g ainar-g

Labels
bug P2: High
Projects
None yet
Milestone
v0.107.0
Development

No branches or pull requests
3 participants
@cunvoas @ainar-g @Disqu3-mirOir-qt