Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate domains in the "Private reverse DNS servers" input #3381

Closed
ainar-g opened this issue Jul 26, 2021 · 1 comment
Closed

Validate domains in the "Private reverse DNS servers" input #3381

ainar-g opened this issue Jul 26, 2021 · 1 comment
Assignees
@EugeneOne1
Labels
enhancement P3: Medium UI
Milestone
v0.107.7

Comments

@ainar-g
Copy link
Contributor

ainar-g commented Jul 26, 2021

In issue 3307 user @Haraguroicha proposed that we should probably the rDNS domains in the “Private reverse DNS servers” input and make sure that they are actually private. That is, make sure that all upstreams of the form [NNN.in-addr.arpa]1.2.3.4 have the NNN part of the domain that points to a locally served network. I'm not sure if this should be done on the backend, but it would definitely be a good feature for the UI.

@ameshkov, what do you think?
@ainar-g ainar-g self-assigned this Jul 26, 2021
@ainar-g ainar-g mentioned this issue Jul 26, 2021
Closed
3 tasks
@ameshkov
Copy link
Member

That'd be nice to have

@ainar-g ainar-g added this to the v0.108.0 milestone Jul 28, 2021
@ainar-g ainar-g assigned EugeneOne1 and unassigned ainar-g Jan 27, 2022
adguard pushed a commit to AdguardTeam/golibs that referenced this issue Feb 11, 2022
@EugeneOne1
Pull request: netutil: parse arpa subnet
e35f9f2 
Merge in DNS/golibs from parse-arpa-subnet to master

Updates AdguardTeam/AdGuardHome#3381.

Squashed commit of the following:

commit 35899cc
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Fri Feb 11 18:21:54 2022 +0300

    netutil: fix docs

commit 917a851
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Fri Feb 11 18:13:00 2022 +0300

    netutil: fix leading zeros

commit 52db891
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Fri Feb 11 16:42:42 2022 +0300

    netutil: imp code, docs, tests

commit 420e442
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Fri Feb 11 15:17:09 2022 +0300

    netutil: add arpa subnet parser
@pugs686 pugs686 mentioned this issue Mar 9, 2022
Closed
@ainar-g ainar-g modified the milestones: v0.108.0, v0.107.7 Jun 2, 2022
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 3381 check private domains
8f16207 
Merge in DNS/adguard-home from 3381-validate-privateness to master

Closes AdguardTeam#3381.

Squashed commit of the following:

commit 21cb12d
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Feb 14 16:29:59 2022 +0300

    all: imp code, docs

commit 3979355
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Feb 14 15:08:36 2022 +0300

    all: imp code, docs

commit 6b71848
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Feb 14 14:22:00 2022 +0300

    all: check private domains
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
enhancement P3: Medium UI
Projects
None yet
Milestone
v0.107.7
Development

No branches or pull requests
3 participants
@ainar-g @ameshkov @EugeneOne1