Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept client IDs from hostnames in DoH as well #3418

Closed
ainar-g opened this issue Aug 4, 2021 · 1 comment
Closed

Accept client IDs from hostnames in DoH as well #3418

ainar-g opened this issue Aug 4, 2021 · 1 comment
Assignees
@ainar-g
Labels
feature request P4: Low
Milestone
v0.107.17

Comments

@ainar-g
Copy link
Contributor

ainar-g commented Aug 4, 2021

Currently, the DoQ and DoT servers accept client IDs from the hostname (e.g. CLIENT-1.example.com), while the DoH one, from the path in the URL (e.g. https://example.com/dns-query/CLIENT-1). @ameshkov proposes that the DoH server should also try and get the client ID from the hostname, but only if there is no client ID in the URL path. That is, a request for https://CLIENT-1.example.com/dns-query/CLIENT-2 will be processed as a request for CLIENT-2 and not CLIENT-1.

@ameshkov, is this correct?
@ainar-g ainar-g added this to the v0.108.0 milestone Aug 4, 2021
@ameshkov
Copy link
Member

ameshkov commented Aug 4, 2021

That's right

@ainar-g ainar-g self-assigned this Dec 21, 2021
@adguard adguard closed this as completed in 330ac30 Oct 5, 2022
@ainar-g ainar-g modified the milestones: v0.108.0, v0.107.16 Oct 5, 2022
@ainar-g ainar-g modified the milestones: v0.107.18, v0.107.17 Nov 2, 2022
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@ainar-g @heyxkhoa
Pull request: 3418-clientid-doh
d0af948 
Closes AdguardTeam#3418.

Squashed commit of the following:

commit 8a1180f
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Oct 5 17:26:22 2022 +0300

    all: imp docs, tests

commit 9629c69
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Oct 5 15:34:33 2022 +0300

    dnsforward: accept clientids from doh client srvname
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ainar-g ainar-g

Labels
feature request P4: Low
Projects
None yet
Milestone
v0.107.17
Development

No branches or pull requests
2 participants
@ainar-g @ameshkov