Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Endlessly adding client IP to blocklist #3419

Closed
Chinaski1 opened this issue Aug 4, 2021 · 0 comments
Closed

Endlessly adding client IP to blocklist #3419

Chinaski1 opened this issue Aug 4, 2021 · 0 comments
Assignees
@105th
Labels
bug P4: Low
Milestone
v0.107.0

Comments

@Chinaski1
Copy link
Member

Issue Details

  1. Add client IP to allowlist
  2. Try to block it from the Main menu or Query log
  3. No matter how many times you click on the block, the client will remain in the allowlist and the entries will continue to accumulate in the blocklist

Video with the issue is attached in Jira
@ainar-g ainar-g added the bug label Aug 4, 2021
adguard pushed a commit that referenced this issue Sep 10, 2021
@105th @ainar-g
Pull request: 3419 client allowlist collision
8fdd789 
Updates #3419.

Squashed commit of the following:

commit 370094c
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date:   Fri Sep 10 17:31:16 2021 +0300

    added link to github issue

commit 407ba9b
Merge: 426c814 8054823
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date:   Fri Sep 10 17:29:52 2021 +0300

    Merge branch 'master' into 3419-client-allowlist-collision

commit 426c814
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date:   Fri Sep 10 16:28:11 2021 +0300

    fix en

commit d28c602
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date:   Fri Sep 10 15:49:12 2021 +0300

    added missing space

commit b374a09
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date:   Fri Sep 10 15:43:55 2021 +0300

    fixes after review

commit 2be629d
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date:   Thu Sep 9 14:17:19 2021 +0300

    fixes

commit 5c2aa62
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date:   Wed Sep 8 15:04:30 2021 +0300

    return empty line to locale file

commit 3631c37
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date:   Wed Sep 8 13:57:51 2021 +0300

    all: fix collisions in access lists && expand block/unblock client
@ainar-g ainar-g added this to the v0.107.0 milestone Sep 14, 2021
@ainar-g ainar-g closed this as completed Sep 14, 2021
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@105th @heyxkhoa
Pull request: 3419 client allowlist collision
b0e1704 
Updates AdguardTeam#3419.

Squashed commit of the following:

commit 370094c
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date:   Fri Sep 10 17:31:16 2021 +0300

    added link to github issue

commit 407ba9b
Merge: 426c814 8054823
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date:   Fri Sep 10 17:29:52 2021 +0300

    Merge branch 'master' into 3419-client-allowlist-collision

commit 426c814
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date:   Fri Sep 10 16:28:11 2021 +0300

    fix en

commit d28c602
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date:   Fri Sep 10 15:49:12 2021 +0300

    added missing space

commit b374a09
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date:   Fri Sep 10 15:43:55 2021 +0300

    fixes after review

commit 2be629d
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date:   Thu Sep 9 14:17:19 2021 +0300

    fixes

commit 5c2aa62
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date:   Wed Sep 8 15:04:30 2021 +0300

    return empty line to locale file

commit 3631c37
Author: Dmitriy Seregin <d.seregin@adguard.com>
Date:   Wed Sep 8 13:57:51 2021 +0300

    all: fix collisions in access lists && expand block/unblock client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@105th 105th

Labels
bug P4: Low
Projects
None yet
Milestone
v0.107.0
Development

No branches or pull requests
3 participants
@ainar-g @105th @Chinaski1