Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DHCP server should take request's broadcast flag into account #3443

Closed
EugeneOne1 opened this issue Aug 13, 2021 · 1 comment
Closed

DHCP server should take request's broadcast flag into account #3443

EugeneOne1 opened this issue Aug 13, 2021 · 1 comment
Assignees
@EugeneOne1
Labels
enhancement P2: High
Milestone
v0.107.0

Comments

@EugeneOne1
Copy link
Member

EugeneOne1 commented Aug 13, 2021 •
edited
Loading

DHCP Discover requests may have a broadcast flag. As Wikipedia states:

Additionally, there is a BROADCAST flag (1 bit in 2 byte flags field, where all other bits are reserved and so are set to 0) the client can use to indicate in which way (broadcast or unicast) it can receive the DHCPOFFER [...]

Responding to the broadcast address may sometimes be necessary for some clients so the flag should be handled properly.

Additionally, we should respect the behaviour described in the RFC regarding the sending of addresses depending on what information we have about the client (e.g. when we only have a hardware address).

We should consider writing these messages to all interfaces where we can. A separate issue will be filled regarding the mental model of it all.
@EugeneOne1 EugeneOne1 added this to the v0.108.0 milestone Aug 13, 2021
@anbraten anbraten mentioned this issue Aug 16, 2021
Closed
2 tasks
@EugeneOne1 EugeneOne1 mentioned this issue Aug 20, 2021
Closed
@EugeneOne1
Copy link
Member Author

RFC-2131 Section 4.1 extends this issue defining a few additional relations between broadcast flag and other DHCP message fields to consider.

@ainar-g ainar-g modified the milestones: v0.108.0, v0.107.0 Sep 2, 2021
adguard pushed a commit that referenced this issue Sep 7, 2021
@EugeneOne1
Pull request: 3443 dhcp broadcast
b77ceaa 
Merge in DNS/adguard-home from 3443-fix-wired-dhcp to master

Updates #3443.

Squashed commit of the following:

commit ec7c3b7
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Sep 7 18:21:07 2021 +0300

    dhcpd: imp docs & naming

commit d87c646
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Sep 7 16:56:36 2021 +0300

    dhcpd: fix build tags & log changes

commit cbd0b3c
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Sep 7 16:26:50 2021 +0300

    dhcpd: revert 3443 & imp broadcasting
@EugeneOne1 EugeneOne1 mentioned this issue Oct 18, 2021
Closed
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 3443 dhcp broadcast
570fe52 
Merge in DNS/adguard-home from 3443-fix-wired-dhcp to master

Updates AdguardTeam#3443.

Squashed commit of the following:

commit ec7c3b7
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Sep 7 18:21:07 2021 +0300

    dhcpd: imp docs & naming

commit d87c646
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Sep 7 16:56:36 2021 +0300

    dhcpd: fix build tags & log changes

commit cbd0b3c
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Sep 7 16:26:50 2021 +0300

    dhcpd: revert 3443 & imp broadcasting
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 3443 dhcp broadcast vol.2
d630968 
Merge in DNS/adguard-home from 3443-dhcp-broadcast-vol.2 to master

Closes AdguardTeam#3443.

Squashed commit of the following:

commit a85af89
Merge: 72eb3a8 a4e0782
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Thu Sep 30 18:08:19 2021 +0300

    Merge branch 'master' into 3443-dhcp-broadcast-vol.2

commit 72eb3a8
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Thu Sep 30 18:03:19 2021 +0300

    dhcpd: imp code readability

commit 2d1fbc4
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Thu Sep 30 14:16:59 2021 +0300

    dhcpd: imp tests

commit 889fad3
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed Sep 29 20:09:25 2021 +0300

    dhcpd: imp code, docs

commit 1fd6b23
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Thu Sep 23 16:08:18 2021 +0300

    dhcpd: unicast to mac address
@Zevensoft Zevensoft mentioned this issue Apr 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
enhancement P2: High
Projects
None yet
Milestone
v0.107.0
Development

Successfully merging a pull request may close this issue.

feat: support unicast for dhcp replies anbraten/AdGuardHome
2 participants
@ainar-g @EugeneOne1