Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.107.0-b.13 - DHCP 6 ips function is broken, worked in official release v0.106.3 #3744

Closed
hijglander opened this issue Oct 17, 2021 · 3 comments
Closed

v0.107.0-b.13 - DHCP 6 ips function is broken, worked in official release v0.106.3 #3744

hijglander opened this issue Oct 17, 2021 · 3 comments
Assignees
@EugeneOne1
Labels
bug P2: High
Milestone
v0.107.0

Comments

@hijglander
Copy link

  • [ X] I am running the latest BETA version. v0.107.0-b.13
  • [ X] I checked the documentation and found no answer
  • [ X] I checked to make sure that this issue has not already been filed

Issue Details

  • Version of AdGuard Home server:
    • AdGuard Home, version v0.107.0-b.13
  • How did you install AdGuard Home:
    • GitHub releases
  • How did you setup DNS configuration:
    • Via Adguard
  • If it's a router or IoT, please write device model:
    • Raspberry Pi 4 Model B && Raspberry Pi 3 Model B
  • CPU architecture:
    • ARMv7
  • Operating system and version:
    • Debian v11 && Rasbian v10

Expected Behavior

Two DNS servers get propagated via DHCP to the DHCP Clients

Actual Behavior

Only the IP of the Adguard installation is advertised to the clients.. switching back to the official release fixes this issue.
@ainar-g ainar-g added the needs investigation Needs to be reproduced reliably. label Oct 18, 2021
@EugeneOne1
Copy link
Member

@hijglander, hello and thanks for the report! We can reproduce it and it's a legit bug. Going to fix it in the nearest time.

@EugeneOne1 EugeneOne1 added bug and removed needs investigation Needs to be reproduced reliably. labels Oct 18, 2021
@EugeneOne1 EugeneOne1 added this to the v0.107.0 milestone Oct 18, 2021
adguard pushed a commit that referenced this issue Oct 18, 2021
@EugeneOne1
Pull request: 3744 DNS server DHCP option
b296fa2 
Merge in DNS/adguard-home from 3744-options-priority to master

Updates #3744.

Squashed commit of the following:

commit 30f1d48
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Oct 18 15:22:49 2021 +0300

    dhcpd: imp tests more

commit 9a8194e
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Oct 18 15:09:20 2021 +0300

    dhcpd: imp tests

commit d915e0b
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Oct 18 14:46:20 2021 +0300

    dhcpd: fix options priority
@EugeneOne1
Copy link
Member

EugeneOne1 commented Oct 18, 2021 •
edited

@hijglander, we've just updated the edge channel with build that should fix this issue. Could you please install it and check if it now uses the values from configuration file?

@hijglander
Copy link
Author

Hi @EugeneOne1 , I downloaded the edge channel build (rasberrypi version) and can confirm that the bug is fixed. All DHCP clients now receive both DNS IP's again.
Thanks!

heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 3744 DNS server DHCP option
24ac116 
Merge in DNS/adguard-home from 3744-options-priority to master

Updates AdguardTeam#3744.

Squashed commit of the following:

commit 30f1d48
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Oct 18 15:22:49 2021 +0300

    dhcpd: imp tests more

commit 9a8194e
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Oct 18 15:09:20 2021 +0300

    dhcpd: imp tests

commit d915e0b
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Oct 18 14:46:20 2021 +0300

    dhcpd: fix options priority
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
bug P2: High
Projects
None yet
Milestone
v0.107.0
Development

No branches or pull requests
3 participants
@ainar-g @hijglander @EugeneOne1