Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPT records aren't filtered out for non-DNSSEC requests #3904

Closed
ainar-g opened this issue Nov 30, 2021 · 0 comments
Closed

OPT records aren't filtered out for non-DNSSEC requests #3904

ainar-g opened this issue Nov 30, 2021 · 0 comments
Assignees
Milestone

Comments

@ainar-g
Copy link
Contributor

ainar-g commented Nov 30, 2021

Compare:

dnslookup 'example.org' '8.8.8.8'
dnslookup result:
;; opcode: QUERY, status: NOERROR, id: 64559
;; flags: qr rd ra; QUERY: 1, ANSWER: 1, AUTHORITY: 0, ADDITIONAL: 0

;; QUESTION SECTION:
;example.org.   IN       A

;; ANSWER SECTION:
example.org.    2820    IN      A       93.184.216.34

vs.

dnslookup 'example.org' "$ADGUARD_HOME_ADDR"
dnslookup result:
;; opcode: QUERY, status: NOERROR, id: 1356
;; flags: qr rd ra ad; QUERY: 1, ANSWER: 1, AUTHORITY: 0, ADDITIONAL: 1

;; QUESTION SECTION:
;example.org.   IN       A

;; ANSWER SECTION:
example.org.    11485   IN      A       93.184.216.34

;; ADDITIONAL SECTION:

;; OPT PSEUDOSECTION:
; EDNS: version 0; flags: do; udp: 4096
@ainar-g ainar-g added this to the v0.107.0 milestone Nov 30, 2021
@ainar-g ainar-g self-assigned this Nov 30, 2021
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Closes AdguardTeam#3904.

Squashed commit of the following:

commit 5948f0d
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Mon Dec 13 17:53:40 2021 +0300

    querylog: imp

commit 852cc7d
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Mon Dec 13 17:44:41 2021 +0300

    querylog: fix entry write

commit 9d58046
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Mon Dec 13 16:45:56 2021 +0300

    all: simplify dnssec logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant