Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

从 v0.107.0-b.14 起,没有正确查询域名 #3946

Closed
ShuiHuo opened this issue Dec 16, 2021 · 9 comments
Closed

从 v0.107.0-b.14 起,没有正确查询域名 #3946

ShuiHuo opened this issue Dec 16, 2021 · 9 comments
Assignees
Milestone

Comments

@ShuiHuo
Copy link

ShuiHuo commented Dec 16, 2021

I do not speak English, so I will use simplified Chinese for feedback

Issue Details

  • Version of AdGuard Home server:
    • v0.107.0-b.14
    • v0.107.0-b.15
    • v0.107.0-b.16 / RC1
  • How did you install AdGuard Home:
    • GitHub releases
  • How did you setup DNS configuration:
    • Router
  • If it's a router or IoT, please write device model:
    • Newifi-D2
  • CPU architecture:
    • MIPS
  • Operating system and version:
    *OpenWrt 21.02-SNAPSHOT r16335-4b0f87729c

Expected Behavior

查询域名并返回正确的地址

Actual Behavior

所有域名都变成了重写项

Screenshots

Screenshot:

2021-12-16_08-12

Additional Information

v0.107.0-b.13 时是正常的,使用完全相同的配置,仅 AdguardHome 软件版本不同。

@ShuiHuo ShuiHuo changed the title 从 v0.107.0-b.15 起,没有正确查询域名 从 v0.107.0-b.14 起,没有正确查询域名 Dec 16, 2021
@two-dogs
Copy link

i thought i would help, the translation from @ShuiHuo expected and actual behavior according to DDG is,
expect: querying the domain name and returning the correct address
actual: The domain name becomes a rewrite entry

@ainar-g
Copy link
Contributor

ainar-g commented Dec 16, 2021

Thanks for the report! It seems like the issue at hand is that if the /etc/hosts file contains invalid hostnames with an * character, they become wildcard rules that rewrite things they shouldn't. We'll fix it in RC2.

@ainar-g ainar-g self-assigned this Dec 16, 2021
@ainar-g ainar-g added this to the v0.107.0 milestone Dec 16, 2021
adguard pushed a commit that referenced this issue Dec 16, 2021
Updates #3946.

Squashed commit of the following:

commit 5d632dc
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Dec 16 15:49:51 2021 +0300

    aghnet: imp code

commit 4da620e
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Dec 16 15:33:39 2021 +0300

    aghnet: do not turn bad etc/hosts entries into rules
@ainar-g
Copy link
Contributor

ainar-g commented Dec 16, 2021

@ShuiHuo, should be fixed in version v0.107.0-a.240+4be69d35 on the edge release channel. Could you please check if this works for you?

@ShuiHuo
Copy link
Author

ShuiHuo commented Dec 16, 2021

@ShuiHuo, should be fixed in version v0.107.0-a.240+4be69d35 on the edge release channel. Could you please check if this works for you?

Where can I download binaries

@ShuiHuo
Copy link
Author

ShuiHuo commented Dec 16, 2021

https://static.adguard.com/adguardhome/edge/AdGuardHome_linux_mipsle_softfloat.tar.gz

v0.107.0-a.240+4be69d35

Custom filtering rules are not controlled by the global protection button, and are filtered regardless of whether protection is enabled or disabledScreenshot_20211217_055701

@ameshkov
Copy link
Member

ameshkov commented Dec 17, 2021

Custom filtering rules are not controlled by the global protection button, and are filtered regardless of whether protection is enabled or disabled

This is by design: #1558

@ShuiHuo
Copy link
Author

ShuiHuo commented Dec 17, 2021

Custom filtering rules are not controlled by the global protection button, and are filtered regardless of whether protection is enabled or disabled

This is by design: #1558

How can I quickly switch the status of custom filtering rules on or off?

@ainar-g
Copy link
Contributor

ainar-g commented Dec 17, 2021

@ShuiHuo, there are several ways:

  1. Uncheck the “Block domains using filters and hosts files” on the “Settings → General settings” page. This will disable all filtering based on filtering lists and rewrites.

  2. Just comment them out. The rules syntax supports comments with the # character.

  3. Make these rules apply only for clients by using the $client modifier.

There isn't currently one flag to completely disable them, but there are related feature requests: #1765, #2551.

We'll close this issue for now, since the original problem seems to be resolved on the edge release channel. Please feel free to ask questions on the Discussions page or open new issues about bugs. Thanks.

@ainar-g ainar-g closed this as completed Dec 17, 2021
@lex-obrien
Copy link

Interesting side effect of this is that domains with "_"s are also ignored as well. It makes sense as public domains cannot have underscores, but it was bothering me seeing all of those error messages in my logs. I'll just change my host names, but I wanted to drop the note in case anyone else runs into this ;)

heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Updates AdguardTeam#3946.

Squashed commit of the following:

commit 5d632dc
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Dec 16 15:49:51 2021 +0300

    aghnet: imp code

commit 4da620e
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Dec 16 15:33:39 2021 +0300

    aghnet: do not turn bad etc/hosts entries into rules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants