Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking DNS Service Discovery in v0.107 #4120

Closed
EugeneOne1 opened this issue Jan 10, 2022 · 0 comments
Closed

Breaking DNS Service Discovery in v0.107 #4120

EugeneOne1 opened this issue Jan 10, 2022 · 0 comments
Assignees
@EugeneOne1
Labels
bug external libs Issues that require changes in external libraries. P3: Medium
Milestone
v0.107.3

Comments

@EugeneOne1
Copy link
Member

Latest stable release of AdGuard Home breaks the DNS Service Discovery. It essentially can't deal with special symbols like underscores or spaces in DNS-SD's domain names.

It seems the commit introduced the change is 9bd7294. The bug is the result of adding the validation of a domain name within the processRestrictLocal when moving some functionality to netutil.

We should definitely inspect the validation process and perhaps improve or get rid of it in this specific place.
@EugeneOne1 EugeneOne1 added bug external libs Issues that require changes in external libraries. P3: Medium labels Jan 10, 2022
@EugeneOne1 EugeneOne1 added this to the v0.107.3 milestone Jan 11, 2022
@EugeneOne1 EugeneOne1 self-assigned this Jan 11, 2022
@ameshkov ameshkov mentioned this issue Jan 11, 2022
Open
adguard pushed a commit to AdguardTeam/golibs that referenced this issue Jan 18, 2022
@EugeneOne1
Pull request: 4120 validate services names
8e3d818 
Merge in DNS/golibs from 4120-service-labels to master

Updates AdguardTeam/AdGuardHome#4120.

Squashed commit of the following:

commit b6d2b5d
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Jan 18 13:20:06 2022 +0300

    netutil: add parallel

commit 09b6f23
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Jan 17 20:40:11 2022 +0300

    netutil: imp code quality

commit b75314e
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Jan 17 18:57:44 2022 +0300

    netutil: validate services names
adguard pushed a commit that referenced this issue Jan 21, 2022
@EugeneOne1 @ainar-g
cherry-pick: 4120 service domain validation
f41332f 
Merge in DNS/adguard-home from 4120-fix-services to master

Closes #4120.

Squashed commit of the following:

commit ca2e5fa
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Jan 18 14:14:54 2022 +0300

    dnsforward: imp docs

commit 9ed5f53
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Jan 18 13:50:33 2022 +0300

    dnsforward: fix reverse domain validation
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 4120 service domain validation
f5c9713 
Merge in DNS/adguard-home from 4120-fix-services to master

Closes AdguardTeam#4120.

Squashed commit of the following:

commit ca2e5fa
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Jan 18 14:14:54 2022 +0300

    dnsforward: imp docs

commit 9ed5f53
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Jan 18 13:50:33 2022 +0300

    dnsforward: fix reverse domain validation
@GTVolk GTVolk mentioned this issue Nov 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
bug external libs Issues that require changes in external libraries. P3: Medium
Projects
None yet
Milestone
v0.107.3
Development

No branches or pull requests
1 participant
@EugeneOne1