Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support hostnames for plain DNS upstream servers #4166

Closed
EugeneOne1 opened this issue Jan 19, 2022 · 2 comments
Closed

Support hostnames for plain DNS upstream servers #4166

EugeneOne1 opened this issue Jan 19, 2022 · 2 comments
Assignees
@EugeneOne1
Labels
external libs Issues that require changes in external libraries. P4: Low
Milestone
v0.107.7

Comments

@EugeneOne1
Copy link
Member

AdGuard Home currently supports specifying an upstream server by hostname with the following schemes:

  • tcp:// for plain DNS-over-TCP;
  • tls:// for DNS-over-TLS;
  • https:// for DNS-over-HTTPS;
  • sdns:// for DNSCrypt;
  • quic:// for DNS-over-QUIC;
  • IP address without protocol for plain DNS-over-UDP.

So far, there is no way to specify a plain DNS upstream server defined by a hostname. We should definitely provide an abillity to use a hostname as well as an IP address for that. Perhaps, we may introduce the new udp:// scheme.
@EugeneOne1 EugeneOne1 added P4: Low external libs Issues that require changes in external libraries. labels Jan 19, 2022
@EugeneOne1 EugeneOne1 added this to the v0.108.0 milestone Jan 19, 2022
@EugeneOne1 EugeneOne1 self-assigned this Jan 19, 2022
@EugeneOne1 EugeneOne1 mentioned this issue Jan 19, 2022
Closed
3 tasks
adguard pushed a commit to AdguardTeam/dnsproxy that referenced this issue Mar 1, 2022
@EugeneOne1
Pull request: 4166 support udp scheme
8e93531 
Merge in DNS/dnsproxy from 4166-udp-upstream to master

Updates AdguardTeam/AdGuardHome#4166.

Squashed commit of the following:

commit 571134e
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Mar 1 16:59:21 2022 +0300

    upstream: fix docs, revert opts order, imp code

commit 652588c
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Mon Feb 7 18:03:42 2022 +0300

    upstream: support udp scheme
@adguard adguard closed this as completed in e0b557e Mar 2, 2022
@agneevX
Copy link
Contributor

agneevX commented Mar 7, 2022

Per the code, I assume bootstrap servers are used to resolve hostnames @EugeneOne1?

So, in a Docker network, the DNS server is at 127.0.0.11:53. In order to resolve the hostnames of containers, the first bootstrap server should be set to that, correct?

@ainar-g ainar-g modified the milestones: v0.108.0, v0.107.7 Jun 2, 2022
adguard pushed a commit that referenced this issue Jun 2, 2022
@EugeneOne1 @ainar-g
cherry-pick: 4166 udp upstream
941cd2a 
Merge in DNS/adguard-home from 4166-udp-upstream to master

Closes #4166.

Squashed commit of the following:

commit b8b6d1c
Merge: e5f0127 ea6e033
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Mar 1 20:36:40 2022 +0300

    Merge branch 'master' into 4166-udp-upstream

commit e5f0127
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Mar 1 19:41:33 2022 +0300

    client: upd upstream examples

commit bd974f2
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Mar 1 18:36:10 2022 +0300

    all: upd proxy

commit badf132
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Fri Feb 4 14:36:50 2022 +0300

    WIP
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 4166 udp upstream
b1085f5 
Merge in DNS/adguard-home from 4166-udp-upstream to master

Closes AdguardTeam#4166.

Squashed commit of the following:

commit b8b6d1c
Merge: e5f0127 ea6e033
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Mar 1 20:36:40 2022 +0300

    Merge branch 'master' into 4166-udp-upstream

commit e5f0127
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Mar 1 19:41:33 2022 +0300

    client: upd upstream examples

commit bd974f2
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Tue Mar 1 18:36:10 2022 +0300

    all: upd proxy

commit badf132
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Fri Feb 4 14:36:50 2022 +0300

    WIP
@EugeneOne1
Copy link
Member Author

@agneevX, actually no. We've filled the AdguardTeam/dnsproxy#324 about it, and it's currently in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
external libs Issues that require changes in external libraries. P4: Low
Projects
None yet
Milestone
v0.107.7
Development

No branches or pull requests
3 participants
@ainar-g @agneevX @EugeneOne1