Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with "FQDN Client" #4542

Closed
CordoWEB opened this issue Apr 30, 2022 · 9 comments
Closed

Bug with "FQDN Client" #4542

CordoWEB opened this issue Apr 30, 2022 · 9 comments
Assignees
Milestone

Comments

@CordoWEB
Copy link

CordoWEB commented Apr 30, 2022

When a client use AdguardHome server with a FQDN, "theclient.domain.fr" & "TheClient.domain.fr" are view like differents clients.
This is not good for stats ;(

Adguard Home v0.107.6 on Linux Ubuntu 22.04 et Linux Centos 6.10.

@agneevX
Copy link
Contributor

agneevX commented May 1, 2022

When a client use AdguardHome server with a FQDN, "theclient.domain.fr" & "TheClient.domain.fr" are view like differents clients.

This is a bit weird because domain names are case-insensitive. I have a bunch of clients with advertised NetBIOS names in Pascal case, but AGH normalizes them, as it should.

@CordoWEB
Copy link
Author

CordoWEB commented May 1, 2022

AdGuard

My FQDN is dns-spf.xxxxxxxx.xxx but someone use Dns-spf.xxxxxxxx.xxx in "private DNS" on Android and i have this.

@agneevX
Copy link
Contributor

agneevX commented May 1, 2022

but someone use Dns-spf.xxxxxxxx.xxx in "private DNS" on Android and i have this.

You mean to tell me you're running an open resolver?

@CordoWEB
Copy link
Author

CordoWEB commented May 1, 2022

Yes but filter by firewall :)

@EugeneOne1
Copy link
Member

@CordoWEB, hello and thanks for the report. We're able to reproduce the bug, the ClientID string is indeed case-sensitive for the moment. We're going to fix it soon.

@EugeneOne1 EugeneOne1 added the bug label May 4, 2022
@EugeneOne1 EugeneOne1 self-assigned this May 4, 2022
@CordoWEB
Copy link
Author

CordoWEB commented May 4, 2022

@CordoWEB, hello and thanks for the report. We're able to reproduce the bug, the ClientID string is indeed case-sensitive for the moment. We're going to fix it soon.

Thank you so much :)

adguard pushed a commit that referenced this issue May 4, 2022
Merge in DNS/adguard-home from 4542-clientid-case to master

Updates #4542.

Squashed commit of the following:

commit 2a3111e
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed May 4 20:44:18 2022 +0300

    all: fix changelog link

commit 3732def
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed May 4 20:43:37 2022 +0300

    all: log changes

commit 9fe1001
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed May 4 19:37:33 2022 +0300

    dnsforward: lowercase clientid
@EugeneOne1
Copy link
Member

@CordoWEB, hello again. We've just pushed the latest edge build, that should fix the issue. Could you please check if it does?

@CordoWEB
Copy link
Author

CordoWEB commented May 5, 2022

I'm sorry i don't have "test environment"

@EugeneOne1
Copy link
Member

@CordoWEB, well, the issue seems resolved, at least on our test machines, so I'll close it for now. Please, feel free to reopen it in case you'll face it again. Thanks again.

@EugeneOne1 EugeneOne1 added this to the v0.108.0 milestone May 5, 2022
@ainar-g ainar-g modified the milestones: v0.108.0, v0.107.7 Jun 2, 2022
adguard pushed a commit that referenced this issue Jun 2, 2022
Merge in DNS/adguard-home from 4542-clientid-case to master

Updates #4542.

Squashed commit of the following:

commit 2a3111e
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed May 4 20:44:18 2022 +0300

    all: fix changelog link

commit 3732def
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed May 4 20:43:37 2022 +0300

    all: log changes

commit 9fe1001
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed May 4 19:37:33 2022 +0300

    dnsforward: lowercase clientid
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Merge in DNS/adguard-home from 4542-clientid-case to master

Updates AdguardTeam#4542.

Squashed commit of the following:

commit 2a3111e
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed May 4 20:44:18 2022 +0300

    all: fix changelog link

commit 3732def
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed May 4 20:43:37 2022 +0300

    all: log changes

commit 9fe1001
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed May 4 19:37:33 2022 +0300

    dnsforward: lowercase clientid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants