Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-update Feature Fix #4628

Closed
hl2guide opened this issue Jun 4, 2022 · 9 comments
Closed

Auto-update Feature Fix #4628

hl2guide opened this issue Jun 4, 2022 · 9 comments
Assignees
Labels
duplicate Duplicate or merged issues.
Milestone

Comments

@hl2guide
Copy link

hl2guide commented Jun 4, 2022

Issue Details

  • Version of AdGuard Home server:
    • v0.108.0-b.8
  • How did you install AdGuard Home:
    • GitHub releases
  • How did you setup DNS configuration:
    • System
  • CPU architecture:
    • AMD64
  • Operating system and version:
    • Windows 11 Pro 21H2

Expected Behavior

Auto-update applies new version of AdGuard Home successfully.

Actual Behavior

Auto-update fails to apply and suggests a manual update.

No auto-update has succeeded for me for at least 6 versions.

Screenshots

Screenshot:

a

1

Additional Information

None

@Disqu3-mirOir-qt
Copy link

not realy complex just replace binary take 15 second

@hl2guide
Copy link
Author

hl2guide commented Jun 4, 2022

nope it is:

  • annoying
  • manual
  • requires Windows service to be stopped

@ainar-g ainar-g self-assigned this Jun 6, 2022
@ainar-g ainar-g added this to the v0.107.8 milestone Jun 6, 2022
@ainar-g ainar-g added the needs investigation Needs to be reproduced reliably. label Jun 6, 2022
@ainar-g
Copy link
Contributor

ainar-g commented Jun 6, 2022

@hl2guide, can you please collect verbose logs of what happens when you try to update and either add attach them here or send them to devteam@adguard.com? Thanks.

@ainar-g ainar-g added the waiting for data Waiting for users to provide more data. label Jun 6, 2022
@hl2guide
Copy link
Author

hl2guide commented Jun 7, 2022

@ainar-g will do, the next stable release will allow me to test this. I'll post then.

@ainar-g ainar-g modified the milestones: v0.107.8, v0.107.9 Jul 11, 2022
@hl2guide
Copy link
Author

hl2guide commented Jul 14, 2022

@ainar-g When trying to update from v0.107.7 to v0.107.8 I got:

2022/07/14 17:32:50.490443 4848#12 [debug] updater: saving package to file
2022/07/14 17:32:50.496603 4848#12 [debug] updater: unpacking the package
2022/07/14 17:32:50.789365 4848#12 [debug] github.com/AdguardTeam/AdGuardHome/internal/updater.zipFileUnpackOne(): created file D:\Portable Software\PortableApps\PortableApps\AdGuard Home\agh-update-v0.107.8\AdGuardHome.exe
2022/07/14 17:32:50.791514 4848#12 [debug] github.com/AdguardTeam/AdGuardHome/internal/updater.zipFileUnpackOne(): created file D:\Portable Software\PortableApps\PortableApps\AdGuard Home\agh-update-v0.107.8\AdGuardHome.exe.sig
2022/07/14 17:32:50.792625 4848#12 [debug] github.com/AdguardTeam/AdGuardHome/internal/updater.zipFileUnpackOne(): created file D:\Portable Software\PortableApps\PortableApps\AdGuard Home\agh-update-v0.107.8\LICENSE.txt
2022/07/14 17:32:50.794073 4848#12 [debug] github.com/AdguardTeam/AdGuardHome/internal/updater.zipFileUnpackOne(): created file D:\Portable Software\PortableApps\PortableApps\AdGuard Home\agh-update-v0.107.8\README.md
2022/07/14 17:32:50.795074 4848#12 [debug] github.com/AdguardTeam/AdGuardHome/internal/updater.zipFileUnpackOne(): created file D:\Portable Software\PortableApps\PortableApps\AdGuard Home\agh-update-v0.107.8\CHANGELOG.md
2022/07/14 17:32:50.795074 4848#12 [debug] updater: checking configuration
2022/07/14 17:32:51.295210 4848#12 [error] POST /control/update: exec.Command(): exit status 1 1
2022/07/14 17:32:51.463393 4848#134 [debug] github.com/AdguardTeam/dnsproxy/proxy.(*Proxy).udpHandlePacket(): Start handling new UDP packet from 192.168.1.100:60071
2022/07/14 17:32:51.463393 4848#134 [debug] github.com/AdguardTeam/dnsproxy/proxy.(*Proxy).logDNSMessage(): IN: ;; opcode: QUERY, status: NOERROR, id: 17974
;; flags: rd; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 0

@ainar-g ainar-g modified the milestones: v0.107.9, v0.107.10 Aug 3, 2022
@ainar-g ainar-g modified the milestones: v0.107.10, v0.107.11, v0.107.12 Aug 17, 2022
@ainar-g ainar-g modified the milestones: v0.107.12, v0.107.13 Sep 7, 2022
@ainar-g
Copy link
Contributor

ainar-g commented Sep 7, 2022

@hl2guide, sorry for the long silence. There have been quite a few fixes to the autoupdate function recently. Do you still experience the issues?

@hl2guide
Copy link
Author

hl2guide commented Sep 7, 2022

I'll test it in the next stable release.

@hl2guide
Copy link
Author

Seems resolved for me, last autoupdate finally worked 😀 @ainar-g

@ainar-g ainar-g added duplicate Duplicate or merged issues. and removed needs investigation Needs to be reproduced reliably. waiting for data Waiting for users to provide more data. labels Sep 15, 2022
@ainar-g
Copy link
Contributor

ainar-g commented Sep 15, 2022

Hooray! Thank you for checking! Marking as duplicate, since this seems to have been caused by some other issue that had been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Duplicate or merged issues.
Projects
None yet
Development

No branches or pull requests

3 participants