Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate certificate & key for GUI login #4671

Open
ghost opened this issue Jun 15, 2022 · 5 comments
Open

Separate certificate & key for GUI login #4671

ghost opened this issue Jun 15, 2022 · 5 comments

Comments

@ghost
Copy link

ghost commented Jun 15, 2022

AdGuard Home uses the same certificate and key for both GUI login and for DoH clients. Login credentials are also protected by BCrypt, but GUI login should be assigned its own certificate and key.

@cyb3rz3us
Copy link

cyb3rz3us commented Jun 15, 2022

I admit I was surprised by AGH using the same cert\key for the GUI and DNS encryption but I actually can't find a security issue there. Is there a security-based reason for having different certs\keys?

@fernvenue
Copy link
Contributor

I think that if you really want to use different certificate and key, maybe you can just use NGINX or something for your Web UI, that's quite simple.

@ghost
Copy link
Author

ghost commented Jun 20, 2022

Or AGH can implement an option to use exclusively use HTTPS for Web GUI connection, not DoH. I think this is the best option for a local DNS server that serves only LAN clients and is not meant to allow anyone to connect to it over WAN.

@fernvenue
Copy link
Contributor

Or AGH can implement an option to use exclusively use HTTPS for Web GUI connection, not DoH. I think this is the best option for a local DNS server that serves only LAN clients and is not meant to allow anyone to connect to it over WAN.

I hardly think so, this is not AdGuardHome should do, and two different certificates maybe will make the users confuse :(
If you really wanna use two different certificates for LAN/WAN, maybe #4675 (comment) will help you.

@ghost
Copy link
Author

ghost commented Jul 31, 2022

If NGINX is not an option and encryption must be used exclusively for AGH GUI login (never for DoH address resolution), then how should Encryption Settings in AGH be configured?

I noticed that leaving "Server name" blank in AGH Encryption Settings results in AGH log (var\log\AdGuardHome.err) not saying that AGH is listening on DoH port for DoH requests. If "Server name" is provided (as name or IP), then the same log says that AGH is listening for DoH requests on DoH port. Does that mean that leaving "Server name" blank prevents all DoH resolution on that AGH server, but allows for encrypted login?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants