Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent display of client names #4683

Closed
tescophil opened this issue Jun 21, 2022 · 6 comments
Closed

Inconsistent display of client names #4683

tescophil opened this issue Jun 21, 2022 · 6 comments
Assignees
Milestone

Comments

@tescophil
Copy link

tescophil commented Jun 21, 2022

Issue Details

  • Version of AdGuard Home server:
    • AdGuard Home, version v0.107.7
  • How did you install AdGuard Home:
    • GitHub release
  • How did you setup DNS configuration:
    • AGH DNS server assigned by DHCP in router
  • If it's a router or IoT, please write device model:
    • TP-Link Omada ER605
  • CPU architecture:
    • i686
  • Operating system and version:
    • Debian 11

Expected Behavior

I expect either the Canonical Name or the Alias to be displayed in the client list when reading entries from /etc/hosts

Actual Behavior

I have an /etc/hosts file defined with a Canonical Name and and Alias defined for each client

192.168.10.10 my-machine.mydomain.com my-machine # MAC Address

On the list of Top Clients and on the Settings -> Client Settings -> Runtime Clients, some entries show the canonical name and some show the alias, seemingly at random.

I have tried altering the format of the hosts file, with a single space between each entry (default), tabs and fixed width columns, all of which made no difference.

Screenshots

Screenshot:

Additional Information

@EugeneOne1
Copy link
Member

@tescophil, hello and thanks for the report. This is a bug actually, we're going to fix it soon.

@EugeneOne1 EugeneOne1 added the bug label Jun 21, 2022
@tescophil
Copy link
Author

Cool 👍

@EugeneOne1 EugeneOne1 added this to the v0.107.8 milestone Jul 7, 2022
@ainar-g ainar-g added the P4: Low label Jul 7, 2022
adguard pushed a commit that referenced this issue Jul 7, 2022
Updates #4683.

Squashed commit of the following:

commit daa8fda
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Jul 7 19:13:29 2022 +0300

    all: use canonical names for hosts file runtime clients
@ainar-g
Copy link
Contributor

ainar-g commented Jul 7, 2022

@tescophil, the latest edge build, v0.108.0-a.160+3505ce87. Could you please check if it fixes the issue for you?

@tescophil
Copy link
Author

tescophil commented Jul 9, 2022

Happy to give this a go, but have no idea how to install a specific edge version, cant find anything in the docs..., is there a link I can download ?

@tescophil
Copy link
Author

tescophil commented Jul 9, 2022

Update: Managed to find the download link for the latest edge version which is v0.108.0-a.161+77e5e27d

In this version the canonical name is displayed consistently for every host I have (70'ish), which was not the case with the current release.

@ainar-g
Copy link
Contributor

ainar-g commented Jul 11, 2022

Thanks for checking out! We'll close this. Please let us know if you find any new issues.

@ainar-g ainar-g closed this as completed Jul 11, 2022
adguard pushed a commit that referenced this issue Jul 13, 2022
Updates #4683.

Squashed commit of the following:

commit daa8fda
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Jul 7 19:13:29 2022 +0300

    all: use canonical names for hosts file runtime clients
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Updates AdguardTeam#4683.

Squashed commit of the following:

commit daa8fda
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Jul 7 19:13:29 2022 +0300

    all: use canonical names for hosts file runtime clients
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants