-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DHCP] non of the options are transmitted #4705
Comments
@RealKev79, hello. Just to ensure, have you enabled DHCP by setting |
Hi @EugeneOne1 , |
@RealKev79, hello again and sorry for leaving the issue with no attention, but we've came up with an assumption. The current implementation only overwrites the options that should be in the response (we've also described this in the wiki):
Shortly, I suppose the device doesn't request the parameters, you're trying to rewrite. Could you please request any of those with some manual DHCP client? Thanks. |
Hi @EugeneOne1, Is this right or did I get something wrong? Yes my request is a "simple" dhcp-discover (with a dhcp-test-tool), and as you can see in my screenshots above, that my parallel installed DHCPD-Docker responses there directly with all possible options from the config. How should I unterstand the milestone? Would you (the whole team ;-)) check it and "corrected" it in that version, so that all options from the config are then provided? Greetings |
@RealKev79, could you please take a look at the RFC 2131 page 29, the paragraph after the table 3. Doesn't it state that only the explicitly requested options (called "parameters" there) should be returned to the client? However, the same list of statements also contains the item:
Perhaps it means exactly the desired feature. @ainar-g, what do you think? |
Merge in DNS/adguard-home from 4705-fix-opts to master Updates #4705. Squashed commit of the following: commit d3924c4 Merge: e46198c e545f3b Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Mon Sep 5 16:57:38 2022 +0300 Merge branch 'master' into 4705-fix-opts commit e46198c Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Mon Sep 5 16:52:20 2022 +0300 dhcpd: immp docs commit 1c1caea Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Sat Sep 3 17:31:35 2022 +0300 dhcpd: fix logic, imp docs commit bc74e21 Merge: 280ad10 1fb0437 Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Fri Sep 2 18:58:52 2022 +0300 Merge branch 'master' into 4705-fix-opts commit 280ad10 Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Fri Sep 2 00:53:38 2022 +0300 dhcpd: imp docs, tests commit 600fa44 Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Thu Sep 1 20:24:52 2022 +0300 dhcpd: add new opts commit caf0cc6 Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Thu Sep 1 18:13:02 2022 +0300 dhcpd: log changes commit 3d2c61d Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Thu Sep 1 18:09:34 2022 +0300 dhcpd: imp opts
@RealKev79, hello again. We've fixed the DHCP options logic as well as added some new option types for convenient overriding the default ones. You may find the verbose description in the wiki page. The fix is already available in the latest edge build. Could you please check, if the desired options are returned now? |
Hi @EugeneOne1, I have tried the "edge-version" and there everything works fine, as you can see: |
Fine, then I'll close the issue. Thank you for reporting. |
Merge in DNS/adguard-home from 4705-fix-opts to master Updates AdguardTeam#4705. Squashed commit of the following: commit d3924c4 Merge: e46198c e545f3b Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Mon Sep 5 16:57:38 2022 +0300 Merge branch 'master' into 4705-fix-opts commit e46198c Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Mon Sep 5 16:52:20 2022 +0300 dhcpd: immp docs commit 1c1caea Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Sat Sep 3 17:31:35 2022 +0300 dhcpd: fix logic, imp docs commit bc74e21 Merge: 280ad10 1fb0437 Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Fri Sep 2 18:58:52 2022 +0300 Merge branch 'master' into 4705-fix-opts commit 280ad10 Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Fri Sep 2 00:53:38 2022 +0300 dhcpd: imp docs, tests commit 600fa44 Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Thu Sep 1 20:24:52 2022 +0300 dhcpd: add new opts commit caf0cc6 Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Thu Sep 1 18:13:02 2022 +0300 dhcpd: log changes commit 3d2c61d Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Thu Sep 1 18:09:34 2022 +0300 dhcpd: imp opts
Issue Details
Expected Behavior
Entered DHCPv4-options are sended to the client even when not directly requested (like #4152)
Actual Behavior
None of the entered options in the AdGuardHome.yaml (dhcp/dhcpv4/options) are sended to the client.
Screenshots
Screenshot from the config:
Screenshot from responding answer to a discover packet from AGH
Screenshot from responding answer to a discover packet from parallel installed docker-image dhcpd with nearly the same config-options
As seen, dhcpd sends all available options when AGH only sends the absolut minimum
Additional Information
config-file is loaded correctly because in logfile are no errors, and when configured an extremly short lease time (60sec) it is loaded correctly and also is sended to the client
The text was updated successfully, but these errors were encountered: