Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query log UI issue on tablet device #4775

Closed
Alex-302 opened this issue Jul 24, 2022 · 4 comments
Closed

Query log UI issue on tablet device #4775

Alex-302 opened this issue Jul 24, 2022 · 4 comments
Assignees
Milestone

Comments

@Alex-302
Copy link
Member

  • Version of AdGuard Home server: v0.108.0-a.119+1c89394a

Actual Behavior

On iPad, Block button covers client name, and it is hard to press client IP or the name

Better use the same popup as on mobile phone design, when press/click the log item.

Screenshots

Screenshot:

image

Additional Information

@laughtLOOL
Copy link

That not only for iPad, on the any mobile or even PC on small size webiste, when the feature column on the top left need to click to open, that would have that issue

adguard pushed a commit that referenced this issue Aug 2, 2022
Updates #4775

Squashed commit of the following:

commit 9ad85d2
Merge: 95aa29d 41f081d
Author: Ildar Kamalov <ik@adguard.com>
Date:   Tue Aug 2 11:44:04 2022 +0300

    Merge branch 'master' into 4775-popup

commit 95aa29d
Author: Ildar Kamalov <ik@adguard.com>
Date:   Mon Aug 1 16:21:23 2022 +0300

    client: fix query log issue on tablet devices
@ainar-g
Copy link
Contributor

ainar-g commented Aug 3, 2022

We've made some improvements in 053bb72 and a few other commits. The new design (#2554) should not have these issues, so we'll close this one for now.

@ainar-g ainar-g closed this as completed Aug 3, 2022
adguard pushed a commit that referenced this issue Aug 3, 2022
Updates #4775

Squashed commit of the following:

commit 9ad85d2
Merge: 95aa29d 41f081d
Author: Ildar Kamalov <ik@adguard.com>
Date:   Tue Aug 2 11:44:04 2022 +0300

    Merge branch 'master' into 4775-popup

commit 95aa29d
Author: Ildar Kamalov <ik@adguard.com>
Date:   Mon Aug 1 16:21:23 2022 +0300

    client: fix query log issue on tablet devices
@agneevX
Copy link
Contributor

agneevX commented Aug 3, 2022

Hello,

This is quite a bad UI change. Earlier I could tap the question glyphs to hover over the information.
Now it straight away opens a modal meant for mobile devices with no apparent way to close them. This also spans across the entire screen.

This modal pops up when I tap just about anywhere in Query Log.

image

This is also quite buggy. If I simulate a tablet device on desktop, click anywhere, close the modal by pressing Esc and immediately hover over a question glyph, it shows the box.

@ainar-g
Copy link
Contributor

ainar-g commented Aug 3, 2022

@agneevX, clicking outside of the modal closes it for me. Is that not the case for you? Although, I personally would also add an explicit ❌ button.

This modal pops up when I tap just about anywhere in Query Log.

I cannot reproduce that. For me, it only opens when I click on a query log record.

Can you file a new issue, including your OS/browser and the viewport size in the Additional section? Thanks.

heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Updates AdguardTeam#4775

Squashed commit of the following:

commit 9ad85d2
Merge: 95aa29d 41f081d
Author: Ildar Kamalov <ik@adguard.com>
Date:   Tue Aug 2 11:44:04 2022 +0300

    Merge branch 'master' into 4775-popup

commit 95aa29d
Author: Ildar Kamalov <ik@adguard.com>
Date:   Mon Aug 1 16:21:23 2022 +0300

    client: fix query log issue on tablet devices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants