Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AdGuard Home fails to migrate config: "unexpected type of dns: map[string]interface {}" #4846

Closed
3 tasks done
FabioEight opened this issue Aug 18, 2022 · 3 comments
Closed
3 tasks done

AdGuard Home fails to migrate config: "unexpected type of dns: map[string]interface {}" #4846

FabioEight opened this issue Aug 18, 2022 · 3 comments
Assignees
@ainar-g
Labels
bug P2: High
Milestone
v0.107.11

Comments

@FabioEight
Copy link

FabioEight commented Aug 18, 2022 •
edited
Loading

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to report a bug and not ask a question

Operating system type

Linux, Other (please mention the version in the description)

CPU architecture

AMD64

Installation

GitHub releases or script from README

Setup

On a router, DHCP is handled by the router

AdGuard Home version

0.107.10

Description

What did you do?

I tried to install AdGuard using the script:

curl -s -S -L https://raw.githubusercontent.com/AdguardTeam/AdGuardHome/master/scripts/install.sh | sh -s -- -v

Expected result

I got:


root@FakePi3:~# curl -s -S -L https://raw.githubusercontent.com/AdguardTeam/AdGuardHome/master/scripts/install.sh | sh -s -- -v
starting AdGuard Home installation script
channel: release
operating system: linux
cpu type: amd64
AdGuard Home will be installed into /opt/AdGuardHome
checking tar
script is executed with root privileges
no need to uninstall
downloading package from https://static.adtidy.org/adguardhome/release/AdGuardHome_linux_amd64.tar.gz -> AdGuardHome_linux_amd64.tar.gz
successfully downloaded AdGuardHome_linux_amd64.tar.gz
unpacking package from AdGuardHome_linux_amd64.tar.gz into /opt
successfully unpacked, contents: 
total 35388
-rwxrwxrwx 1 root root 36122624 Aug 17 17:44 AdGuardHome
-rw-rw-rw- 1 root root      587 Aug 17 17:44 AdGuardHome.sig
-rw-r--r-- 1 root root    47183 Aug 17 17:44 CHANGELOG.md
-rw-r--r-- 1 root root    35149 Aug 17 17:44 LICENSE.txt
-rw-r--r-- 1 root root    22788 Aug 17 17:44 README.md
2022/08/18 15:04:58 [info] service: control action: install
2022/08/18 15:04:58 [info] service: started
2022/08/18 15:04:58 [info] Almost ready!
AdGuard Home is successfully installed and will automatically start on boot.
There are a few more things that must be configured before you can use it.
Click on the link below and follow the Installation Wizard steps to finish setup.
AdGuard Home is now available at the following addresses:
2022/08/18 15:04:58 [info] Go to http://127.0.0.1:3000
2022/08/18 15:04:58 [info] Go to http://192.168.1.32:3000
2022/08/18 15:04:58 [info] service: action install has been done successfully on linux-systemd
AdGuard Home is now installed and running
you can control the service status with the following commands:
sudo /opt/AdGuardHome/AdGuardHome -s start|stop|restart|status|install|uninstall
root@FakePi3:~# systemctl status adguardhome.service 
● adguardhome.service
     Loaded: not-found (Reason: Unit adguardhome.service not found.)
     Active: failed (Result: exit-code) since Thu 2022-08-18 15:04:10 CEST; 53s ago
   Main PID: 4293 (code=exited, status=1/FAILURE)
        CPU: 8ms

Aug 18 15:04:10 FakePi3 systemd[1]: adguardhome.service: Scheduled restart job, restart counter is at 7.
Aug 18 15:04:10 FakePi3 systemd[1]: Stopped AdGuard Home (DietPi).
Aug 18 15:04:10 FakePi3 systemd[1]: adguardhome.service: Start request repeated too quickly.
Aug 18 15:04:10 FakePi3 systemd[1]: adguardhome.service: Failed with result 'exit-code'.
Aug 18 15:04:10 FakePi3 systemd[1]: Failed to start AdGuard Home (DietPi).

Actual result

AdGuard not installed and service not runnable.

Additional information


Aug 18 15:03:54 FakePi3 systemd[1]: adguardhome.service: Scheduled restart job, restart counter is at 4.
Aug 18 15:03:54 FakePi3 systemd[1]: Stopped AdGuard Home (DietPi).
Aug 18 15:03:54 FakePi3 systemd[1]: Started AdGuard Home (DietPi).
Aug 18 15:03:54 FakePi3 AdGuardHome[4261]: 2022/08/18 15:03:54.911523 [info] AdGuard Home, version v0.107.10
Aug 18 15:03:54 FakePi3 AdGuardHome[4261]: 2022/08/18 15:03:54.911897 [info] Upgrade yaml: 10 to 11
Aug 18 15:03:54 FakePi3 AdGuardHome[4261]: 2022/08/18 15:03:54.911905 [info] Upgrade yaml: 11 to 12
Aug 18 15:03:54 FakePi3 AdGuardHome[4261]: 2022/08/18 15:03:54.911926 [fatal] unexpected type of dns: map[string]interface {}
Aug 18 15:03:54 FakePi3 systemd[1]: adguardhome.service: Main process exited, code=exited, status=1/FAILURE
Aug 18 15:03:54 FakePi3 systemd[1]: adguardhome.service: Failed with result 'exit-code'.
Aug 18 15:04:00 FakePi3 systemd[1]: adguardhome.service: Scheduled restart job, restart counter is at 5.
Aug 18 15:04:00 FakePi3 systemd[1]: Stopped AdGuard Home (DietPi).
Aug 18 15:04:00 FakePi3 systemd[1]: Started AdGuard Home (DietPi).
Aug 18 15:04:00 FakePi3 AdGuardHome[4283]: 2022/08/18 15:04:00.161034 [info] AdGuard Home, version v0.107.10
Aug 18 15:04:00 FakePi3 AdGuardHome[4283]: 2022/08/18 15:04:00.161693 [info] Upgrade yaml: 10 to 11
Aug 18 15:04:00 FakePi3 AdGuardHome[4283]: 2022/08/18 15:04:00.161707 [info] Upgrade yaml: 11 to 12
Aug 18 15:04:00 FakePi3 AdGuardHome[4283]: 2022/08/18 15:04:00.161724 [fatal] unexpected type of dns: map[string]interface {}
Aug 18 15:04:00 FakePi3 systemd[1]: adguardhome.service: Main process exited, code=exited, status=1/FAILURE
Aug 18 15:04:00 FakePi3 systemd[1]: adguardhome.service: Failed with result 'exit-code'.
Aug 18 15:04:05 FakePi3 systemd[1]: adguardhome.service: Scheduled restart job, restart counter is at 6.
Aug 18 15:04:05 FakePi3 systemd[1]: Stopped AdGuard Home (DietPi).
Aug 18 15:04:05 FakePi3 systemd[1]: Started AdGuard Home (DietPi).
Aug 18 15:04:05 FakePi3 AdGuardHome[4293]: 2022/08/18 15:04:05.410209 [info] AdGuard Home, version v0.107.10
Aug 18 15:04:05 FakePi3 AdGuardHome[4293]: 2022/08/18 15:04:05.410605 [info] Upgrade yaml: 10 to 11
Aug 18 15:04:05 FakePi3 AdGuardHome[4293]: 2022/08/18 15:04:05.410614 [info] Upgrade yaml: 11 to 12
Aug 18 15:04:05 FakePi3 AdGuardHome[4293]: 2022/08/18 15:04:05.410634 [fatal] unexpected type of dns: map[string]interface {}
Aug 18 15:04:05 FakePi3 systemd[1]: adguardhome.service: Main process exited, code=exited, status=1/FAILURE
Aug 18 15:04:05 FakePi3 systemd[1]: adguardhome.service: Failed with result 'exit-code'.
Aug 18 15:04:10 FakePi3 systemd[1]: adguardhome.service: Scheduled restart job, restart counter is at 7.
Aug 18 15:04:10 FakePi3 systemd[1]: Stopped AdGuard Home (DietPi).
Aug 18 15:04:10 FakePi3 systemd[1]: adguardhome.service: Start request repeated too quickly.
Aug 18 15:04:10 FakePi3 systemd[1]: adguardhome.service: Failed with result 'exit-code'.
Aug 18 15:04:10 FakePi3 systemd[1]: Failed to start AdGuard Home (DietPi).

I'm using DietPi distro on a HP laptop (amd64).
@ainar-g ainar-g self-assigned this Aug 18, 2022
@ainar-g ainar-g added this to the v0.107.11 milestone Aug 18, 2022
@ainar-g
Copy link
Contributor

ainar-g commented Aug 18, 2022 •
edited
Loading

Thank you for the report! We'll fix this as soon as possible.

In the meantime, it looks like you've already had AdGuard Home installed before? You can probably work around this issue by removing or moving the old configuration file. (Commonly, /opt/AdGuardHome/AdGuardHome.yaml.)

@ainar-g ainar-g mentioned this issue Aug 18, 2022
Closed
3 tasks
@ainar-g ainar-g pinned this issue Aug 18, 2022
@ainar-g ainar-g changed the title Can not install AdGuard Home AdGuard Home fails to migrate config: "unexpected type of dns: map[string]interface {}" Aug 18, 2022
adguard pushed a commit that referenced this issue Aug 18, 2022
@ainar-g
Pull request: 4846-migration-fix
4a7b4d0 
Updates #4846.

Squashed commit of the following:

commit 22e2e89
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Aug 18 16:25:07 2022 +0300

    home: fix yaml object type
@ainar-g
Copy link
Contributor

ainar-g commented Aug 18, 2022

@FabioEight, @jayscovill, version v0.108.0-a.218+4a7b4d03 on the Edge channel should fix this issue. Could any of you please check?

@FabioEight
Copy link
Author

@FabioEight, @jayscovill, version v0.108.0-a.218+4a7b4d03 on the Edge channel should fix this issue. Could any of you please check?

Installed successfully! Thanks for the fast support!

@ainar-g ainar-g closed this as completed Aug 18, 2022
@AlecRust AlecRust mentioned this issue Aug 18, 2022
Closed
marco-m added a commit to marco-m/AdGuardHome that referenced this issue Aug 18, 2022
@marco-m
regression test for unexpected type of dns: map[string]interface
45f7ba0 
This validates 4a7b4d0, fix for AdguardTeam#4846
@marco-m marco-m mentioned this issue Aug 18, 2022
Open
adguard pushed a commit that referenced this issue Aug 19, 2022
@ainar-g
cherry-pick: 4846-migration-fix
39fa4b1 
Updates #4846.

Squashed commit of the following:

commit 22e2e89
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Aug 18 16:25:07 2022 +0300

    home: fix yaml object type
@ainar-g ainar-g unpinned this issue Aug 19, 2022
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@ainar-g @heyxkhoa
Pull request: 4846-migration-fix
fae7986 
Updates AdguardTeam#4846.

Squashed commit of the following:

commit 22e2e89
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Thu Aug 18 16:25:07 2022 +0300

    home: fix yaml object type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ainar-g ainar-g

Labels
bug P2: High
Projects
None yet
Milestone
v0.107.11
Development

No branches or pull requests
2 participants
@ainar-g @FabioEight