Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Application error" log file errors causes DoQ to fail to initialise #5285

Closed
3 tasks done
DandelionSprout opened this issue Dec 20, 2022 · 9 comments
Closed
3 tasks done
Assignees
Milestone

Comments

@DandelionSprout
Copy link
Contributor

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to report a bug and not ask a question

Operating system type

Windows

CPU architecture

AMD64

Installation

GitHub releases or script from README

Setup

On one machine

AdGuard Home version

v0.108.0-b.24

Description

What did you do?

For unclear reasons, setting a DoQ port in Encryption Settings causes a couple dozen [info] got error when accepting a new QUIC stream: APPLICATION_ERROR and [info] got error when accepting a new QUIC stream: Application error 0x1 errors in the log file when "Save configuration" is clicked or when AGH is starting up.

Expected result

Setting a QUIC port, makes AGH initiate its DoQ functionality without problems.

Actual result

Not only does setting a QUIC port fail at initiating DoQ functionality, but it also causes direct IP DNS connections to the server to get stuck and time out.

Screenshots (if applicable)

N/A

Additional information

AdGuardHomeLogFile.txt (Focus especially on the part from 2022/12/20 05:14:11.157532 - 2022/12/20 05:14:30.624020, which was when I tested the problem specifically for this issue report by setting a QUIC port.)

@DandelionSprout
Copy link
Contributor Author

DandelionSprout commented Jun 22, 2023

IP connections seem to work nowadays, but QUIC still results in that error in v0.108.0-b.37.
image

@ainar-g
Copy link
Contributor

ainar-g commented Jun 23, 2023

Apologies for this issue slipping through our attention. If you enable verbose log, do you see [debug] messages like:

closing quic conn … with code …

If so, at least a part of those logs are probably from 0-RTT rejection from upstreams or a short read from a QUIC client, which really shouldn't produce this much messaging.

@Mizzick, we'll probably need better error processing in QUIC servers and upstreams in the DNS proxy module.

@DandelionSprout
Copy link
Contributor Author

I am indeed getting errors pretty similar to what you described, now that I've tested with verbose:

2023/06/23 11:42:25.436780 14368#13370 [error] accepting quic stream: APPLICATION_ERROR (remote)
2023/06/23 11:42:25.436780 14368#13370 [debug] closing quic conn [::]:41396 with code 0

@ainar-g
Copy link
Contributor

ainar-g commented Jun 23, 2023

@DandelionSprout, thanks! It would really help us if you posted a longer log either here or to devteam@adguard.com. That with code 0, at the very least, looks weird, and there may be more weird codes.

@DandelionSprout
Copy link
Contributor Author

Okay, I think I've sent it to that E-mail address now (provided it can receive an 8.5 MB attachment).

adguard pushed a commit to AdguardTeam/dnsproxy that referenced this issue Jun 28, 2023
Updates AdguardTeam/AdGuardHome#5285.

Squashed commit of the following:

commit cc6acb4
Author: Dimitry Kolyshev <dkolyshev@adguard.com>
Date:   Tue Jun 27 16:25:20 2023 +0400

    proxy: quic errors

commit f29f71d
Author: Dimitry Kolyshev <dkolyshev@adguard.com>
Date:   Tue Jun 27 10:51:30 2023 +0400

    proxy: quic errors
adguard pushed a commit that referenced this issue Jun 28, 2023
Updates #5285.

Squashed commit of the following:

commit 8e7d175
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Jun 28 13:33:14 2023 +0300

    all: imp logs; upd dnsproxy
@Mizzick
Copy link
Contributor

Mizzick commented Jun 29, 2023

@DandelionSprout, please check the latest v0.108.0-a.585+c652653e version in the edge channel.

@DandelionSprout
Copy link
Contributor Author

I'll see if I can do so this weekend.

@ainar-g
Copy link
Contributor

ainar-g commented Jun 29, 2023

Just to be clear, the most recent Beta release also includes the fix.

@DandelionSprout
Copy link
Contributor Author

The in-GUI query log seems to imply that DoQ does work properly in b.38 (and that it works alongside all the other DNS connection methods as well). So it seems this can be closed for the time being, and I thank you all for the help with it.

@ainar-g ainar-g modified the milestones: v0.107.34, v0.107.33 Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants