Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log file doesn't include IP addresses for failed login attempts #5701

Closed
3 tasks done
k03mad opened this issue Apr 10, 2023 · 2 comments
Closed
3 tasks done

Log file doesn't include IP addresses for failed login attempts #5701

k03mad opened this issue Apr 10, 2023 · 2 comments
Assignees
@ainar-g
Labels
bug P4: Low
Milestone
v0.107.28

Comments

@k03mad
Copy link

k03mad commented Apr 10, 2023

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to report a bug and not ask a question

Operating system type

Linux, Other (please mention the version in the description)

CPU architecture

AMD64

Installation

GitHub releases or script from README

Setup

On one machine

AdGuard Home version

0.107.27

Description

refs: #2824 (comment)
refs: #2824 (comment)

System

Ubuntu 22.04.2 LTS x86_64

Log options

log_file: /var/log/adghome.log
log_max_backups: 5
log_max_size: 100
log_max_age: 5
log_compress: false
log_localtime: true
verbose: false

Expected result

Log file includes IP addresses for failed login attempts

Actual result

Log file doesn't include IP addresses for failed login attempts (not for attempt / not for auth block)

Looks pretty bad
If someone set up rules for fail2ban - they should have stopped working

Example log screenshot

2023-04-10_20-55-36
@ainar-g ainar-g self-assigned this Apr 11, 2023
@ainar-g ainar-g added this to the v0.107.28 milestone Apr 11, 2023
adguard pushed a commit that referenced this issue Apr 11, 2023
@ainar-g
Pull request 1815: 5701-log-ip
a186b5c 
Updates #5701.

Squashed commit of the following:

commit 332530c
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Apr 11 18:56:27 2023 +0300

    home: imp docs

commit 35a649f
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Apr 11 18:27:25 2023 +0300

    home: fix login attempt logging
@ainar-g
Copy link
Contributor

ainar-g commented Apr 12, 2023

@k03mad, @de-es, this should be improved in the latest Edge releases. Could you please check?

@de-es
Copy link

de-es commented Apr 12, 2023

@ainar-g Works for me now. Thanks a lot.

@ainar-g ainar-g closed this as completed Apr 12, 2023
@ainar-g ainar-g modified the milestones: v0.107.29, v0.107.28 Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ainar-g ainar-g

Labels
bug P4: Low
Projects
None yet
Milestone
v0.107.28
Development

No branches or pull requests
3 participants
@k03mad @ainar-g @de-es