Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dot (.) hostname can not be added to the stats/logs ignore lists #5990

Closed
4 tasks done
cenk opened this issue Jul 10, 2023 · 1 comment
Closed
4 tasks done

Dot (.) hostname can not be added to the stats/logs ignore lists #5990

cenk opened this issue Jul 10, 2023 · 1 comment

Comments

@cenk
Copy link

cenk commented Jul 10, 2023

Prerequisites

Platform (OS and CPU architecture)

Linux/ARMv6

Installation

GitHub releases or script from README

Setup

On one machine

AdGuard Home version

v0.107.33

Action

Try adding dot (.) entry to logs/stats ignore lists.

Expected result

i should be able to add dot hostname.

Actual result

Error: control/querylog/config/update | ignored: host name is empty | 422

Additional information and/or screenshots

dot domain can be added to DNS > Disallowed domains list but showing in statistics list.
IMG_20230710_155428

When i try adding to ignored domains:
IMG_20230710_155541

@cenk
Copy link
Author

cenk commented Jul 10, 2023

Look what I found in aghnet.NewDomainNameSet 😄

// TODO(a.garipov): Think about ignoring empty (".") names in the
// future.

@ainar-g ainar-g self-assigned this Jul 10, 2023
@ainar-g ainar-g added this to the v0.107.34 milestone Jul 10, 2023
adguard pushed a commit that referenced this issue Jul 11, 2023
Updates #5990.

Squashed commit of the following:

commit 1d5d345
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Tue Jul 11 20:11:45 2023 +0300

    all: allow ignoring root in querylog and stats
@ainar-g ainar-g closed this as completed Jul 12, 2023
@ainar-g ainar-g modified the milestones: v0.107.35, v0.107.34 Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants