Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard scrollbar issue #6180

Closed
3 tasks done
gexiaopeng opened this issue Sep 8, 2023 · 7 comments
Closed
3 tasks done

Dashboard scrollbar issue #6180

gexiaopeng opened this issue Sep 8, 2023 · 7 comments
Assignees
@IldarKamalov
Labels
bug P4: Low UI
Milestone
v0.107.40

Comments

@gexiaopeng
Copy link

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to request a feature or enhancement and not ask a question

The problem

Scroll bar appears when there is not much data.
微信图片_20230908142742

Proposed solution

Hide the scrollbar when there is no data or when there is not much data.

Alternatives considered and additional information

No response
@ainar-g
Copy link
Contributor

ainar-g commented Sep 8, 2023

Please do not file bugs under the feature request label.

@ainar-g ainar-g added this to the v0.107.38 milestone Sep 8, 2023
@ainar-g
Copy link
Contributor

ainar-g commented Sep 8, 2023

@gexiaopeng, please add which browser and OS you're using.

@ppfeufer
Copy link

ppfeufer commented Sep 8, 2023 •
edited

Confirmed.

Chrome on Linux
image

Firefox only shows them on mouse enter, but they are there as well.
image

[EDIT]
You can even scroll a little bit, like 20px or so.

@gexiaopeng
Copy link
Author

@gexiaopeng, please add which browser and OS you're using.

Edge and Chrome on Windows10

adguard pushed a commit that referenced this issue Oct 11, 2023
@IldarKamalov
6180 fix dashboard empty tables scroll
3ce3c41 
Updates #6180

Squashed commit of the following:

commit ad4188f
Merge: 8302506 0fb6d61
Author: Ildar Kamalov <ik@adguard.com>
Date:   Wed Oct 11 15:03:55 2023 +0300

    Merge branch 'master' into ADG-7473

commit 8302506
Author: Ildar Kamalov <ik@adguard.com>
Date:   Mon Oct 9 19:43:02 2023 +0300

    Revert "ADG-7473 get table page size from local storage"

    This reverts commit b6bf48a.

commit 960f3a1
Author: Ildar Kamalov <ik@adguard.com>
Date:   Mon Oct 9 19:42:31 2023 +0300

    fix stats config page

commit b6bf48a
Author: Ildar Kamalov <ik@adguard.com>
Date:   Mon Oct 9 19:30:22 2023 +0300

    ADG-7473 get table page size from local storage

commit 7201d00
Author: Ildar Kamalov <ik@adguard.com>
Date:   Mon Oct 9 17:20:48 2023 +0300

    ADG-7473 fix dashboard tables scroll
adguard pushed a commit that referenced this issue Oct 11, 2023
@ainar-g
Pull request 2036: 6180 revert
e218ddc 
Updates #6180.

Squashed commit of the following:

commit 38689bd
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Oct 11 18:24:23 2023 +0300

    Revert "6180 fix dashboard empty tables scroll"

    This reverts commit 3ce3c41.
adguard pushed a commit that referenced this issue Oct 17, 2023
@IldarKamalov
Pull request: 6180 fix dashboard tables scroll
f514f36 
Updates #6180

Squashed commit of the following:

commit eee7fa3
Author: Ildar Kamalov <ik@adguard.com>
Date:   Tue Oct 17 11:47:41 2023 +0300

    fix scroll

commit 0a86a1a
Merge: 07f4550 413f484
Author: Ildar Kamalov <ik@adguard.com>
Date:   Tue Oct 17 10:27:29 2023 +0300

    Merge branch 'master' into ADG-7473-1

commit 07f4550
Author: Ildar Kamalov <ik@adguard.com>
Date:   Fri Oct 13 17:41:47 2023 +0300

    changelog

commit 28a1a73
Author: Ildar Kamalov <ik@adguard.com>
Date:   Fri Oct 13 16:13:59 2023 +0300

    overflow

commit aa38288
Author: Ildar Kamalov <ik@adguard.com>
Date:   Fri Oct 13 16:09:05 2023 +0300

    firefox scroll

commit ac98653
Author: Ildar Kamalov <ik@adguard.com>
Date:   Fri Oct 13 16:06:49 2023 +0300

    constants

commit a3cdd0a
Merge: 0cd8481 506d713
Author: Ildar Kamalov <ik@adguard.com>
Date:   Fri Oct 13 16:03:16 2023 +0300

    Merge branch 'master' into ADG-7473-1

commit 0cd8481
Author: Ildar Kamalov <ik@adguard.com>
Date:   Thu Oct 12 11:13:14 2023 +0300

    changelog

commit ed67807
Author: Ildar Kamalov <ik@adguard.com>
Date:   Thu Oct 12 11:00:23 2023 +0300

    fix rows

commit 5e4f35c
Author: Ildar Kamalov <ik@adguard.com>
Date:   Thu Oct 12 10:58:58 2023 +0300

    ADG-7473 fix dashboard tables scroll
@ainar-g
Copy link
Contributor

ainar-g commented Oct 17, 2023

@gexiaopeng, the latest Edge and Beta releases contain a fix for this and some related issues. Can you please check?

@gexiaopeng
Copy link
Author

gexiaopeng commented Oct 18, 2023 •
edited

@gexiaopeng, the latest Edge and Beta releases contain a fix for this and some related issues. Can you please check?

This issue has been fixed.
1

@gexiaopeng
Copy link
Author

This issue has been fixed.（AdGuard Home v0.108.0-b.48，Edge）

@ainar-g ainar-g closed this as completed Oct 18, 2023
@ainar-g ainar-g modified the milestones: v0.107.41, v0.107.40 Oct 18, 2023
annguyen0 pushed a commit to annguyen0/AdGuardHome that referenced this issue Nov 27, 2023
@IldarKamalov @annguyen0
6180 fix dashboard empty tables scroll
4f82a11 
Updates AdguardTeam#6180

Squashed commit of the following:

commit ad4188f
Merge: 8302506 0fb6d61
Author: Ildar Kamalov <ik@adguard.com>
Date:   Wed Oct 11 15:03:55 2023 +0300

    Merge branch 'master' into ADG-7473

commit 8302506
Author: Ildar Kamalov <ik@adguard.com>
Date:   Mon Oct 9 19:43:02 2023 +0300

    Revert "ADG-7473 get table page size from local storage"

    This reverts commit b6bf48a.

commit 960f3a1
Author: Ildar Kamalov <ik@adguard.com>
Date:   Mon Oct 9 19:42:31 2023 +0300

    fix stats config page

commit b6bf48a
Author: Ildar Kamalov <ik@adguard.com>
Date:   Mon Oct 9 19:30:22 2023 +0300

    ADG-7473 get table page size from local storage

commit 7201d00
Author: Ildar Kamalov <ik@adguard.com>
Date:   Mon Oct 9 17:20:48 2023 +0300

    ADG-7473 fix dashboard tables scroll
annguyen0 pushed a commit to annguyen0/AdGuardHome that referenced this issue Nov 27, 2023
@ainar-g @annguyen0
Pull request 2036: 6180 revert
5d1aa61 
Updates AdguardTeam#6180.

Squashed commit of the following:

commit 38689bd
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Oct 11 18:24:23 2023 +0300

    Revert "6180 fix dashboard empty tables scroll"

    This reverts commit 3ce3c41.
annguyen0 pushed a commit to annguyen0/AdGuardHome that referenced this issue Nov 27, 2023
@IldarKamalov @annguyen0
Pull request: 6180 fix dashboard tables scroll
fd69bd6 
Updates AdguardTeam#6180

Squashed commit of the following:

commit eee7fa3
Author: Ildar Kamalov <ik@adguard.com>
Date:   Tue Oct 17 11:47:41 2023 +0300

    fix scroll

commit 0a86a1a
Merge: 07f4550 413f484
Author: Ildar Kamalov <ik@adguard.com>
Date:   Tue Oct 17 10:27:29 2023 +0300

    Merge branch 'master' into ADG-7473-1

commit 07f4550
Author: Ildar Kamalov <ik@adguard.com>
Date:   Fri Oct 13 17:41:47 2023 +0300

    changelog

commit 28a1a73
Author: Ildar Kamalov <ik@adguard.com>
Date:   Fri Oct 13 16:13:59 2023 +0300

    overflow

commit aa38288
Author: Ildar Kamalov <ik@adguard.com>
Date:   Fri Oct 13 16:09:05 2023 +0300

    firefox scroll

commit ac98653
Author: Ildar Kamalov <ik@adguard.com>
Date:   Fri Oct 13 16:06:49 2023 +0300

    constants

commit a3cdd0a
Merge: 0cd8481 506d713
Author: Ildar Kamalov <ik@adguard.com>
Date:   Fri Oct 13 16:03:16 2023 +0300

    Merge branch 'master' into ADG-7473-1

commit 0cd8481
Author: Ildar Kamalov <ik@adguard.com>
Date:   Thu Oct 12 11:13:14 2023 +0300

    changelog

commit ed67807
Author: Ildar Kamalov <ik@adguard.com>
Date:   Thu Oct 12 11:00:23 2023 +0300

    fix rows

commit 5e4f35c
Author: Ildar Kamalov <ik@adguard.com>
Date:   Thu Oct 12 10:58:58 2023 +0300

    ADG-7473 fix dashboard tables scroll
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IldarKamalov IldarKamalov

Labels
bug P4: Low UI
Projects
None yet
Milestone
v0.107.40
Development

No branches or pull requests
4 participants
@IldarKamalov @ppfeufer @ainar-g @gexiaopeng