Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dialog for adding vetted blocklists taller #6358

Closed
3 tasks done
hl2guide opened this issue Oct 27, 2023 · 4 comments
Closed
3 tasks done

Make dialog for adding vetted blocklists taller #6358

hl2guide opened this issue Oct 27, 2023 · 4 comments

Comments

@hl2guide
Copy link

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to request a feature or enhancement and not ask a question

The problem

In the "Filters > DNS blocklists" page if you:

  • click the "Add blocklist" button
  • click the "Choose from the list" button

the "Choose blocklists" dialog has a small height making it less useful.

Proposed solution

Please consider making it 80% height.

Alternatives considered and additional information

Using as is.

@ainar-g ainar-g added this to the v0.107.41 milestone Oct 27, 2023
@ainar-g ainar-g changed the title Enhanced Add Blocklist Functionality Make dialog for adding vetted blocklists taller Oct 27, 2023
adguard pushed a commit that referenced this issue Nov 3, 2023
Merge in DNS/adguard-home from ADG-7673 to master

Updates #6358.

Squashed commit of the following:

commit c7fc33d
Merge: 82368de ffdebc7
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Fri Nov 3 16:52:26 2023 +0300

    Merge branch 'master' into ADG-7673

commit 82368de
Author: Ildar Kamalov <ik@adguard.com>
Date:   Thu Nov 2 10:07:55 2023 +0300

    changelog

commit e851463
Author: Ildar Kamalov <ik@adguard.com>
Date:   Tue Oct 31 18:31:35 2023 +0300

    ADG-7673 fix filters list height
@EugeneOne1
Copy link
Member

@hl2guide, hello and thanks for the suggestion. We've increased the height of the list and this will be included in the next release, but you can try it already with the latest edge build. Would you mind checking it out?

@hl2guide
Copy link
Author

hl2guide commented Nov 3, 2023

@hl2guide, hello and thanks for the suggestion. We've increased the height of the list and this will be included in the next release, but you can try it already with the latest edge build. Would you mind checking it out?

Where can I find the latest edge build?

@EugeneOne1
Copy link
Member

@hl2guide, it's described in the README.md.

@ainar-g ainar-g closed this as completed Nov 13, 2023
@ainar-g ainar-g modified the milestones: v0.107.42, v0.107.41 Nov 13, 2023
@hl2guide
Copy link
Author

hl2guide commented Nov 16, 2023

Seems like this may not have taken effect.

On a 1440p monitor I get:

example

80% or 90% height would be nice.

annguyen0 pushed a commit to annguyen0/AdGuardHome that referenced this issue Nov 27, 2023
Merge in DNS/adguard-home from ADG-7673 to master

Updates AdguardTeam#6358.

Squashed commit of the following:

commit c7fc33d
Merge: 82368de ffdebc7
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Fri Nov 3 16:52:26 2023 +0300

    Merge branch 'master' into ADG-7673

commit 82368de
Author: Ildar Kamalov <ik@adguard.com>
Date:   Thu Nov 2 10:07:55 2023 +0300

    changelog

commit e851463
Author: Ildar Kamalov <ik@adguard.com>
Date:   Tue Oct 31 18:31:35 2023 +0300

    ADG-7673 fix filters list height
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants
@IldarKamalov @ainar-g @hl2guide @EugeneOne1 and others