Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to set time span when filter lists must be checked for updates #641

Closed
adrianh-za opened this issue Mar 13, 2019 · 10 comments
Closed

Comments

@adrianh-za
Copy link

Please add option to set time span for how often the filter list updates should be checked, in hours or minutes, either will do.

Eg: Every 240 minutes.

@ghost
Copy link

ghost commented Jun 25, 2019

+1 Yes please, it seems that currently it's updated hourly. Pi-hole does it weekly to avoid IPs getting blacklisted for updating too frequently.

@ghost
Copy link

ghost commented Jul 25, 2019

(Set time) #161

@ameshkov ameshkov added this to the v0.99 milestone Aug 4, 2019
@ameshkov
Copy link
Member

ameshkov commented Aug 4, 2019

So here's how it will look like:

  1. We'll add "Filters update period" to the General settings section
  2. Possible values will be:
  • 1 hour
  • 6 hours
  • 12 hours
  • 24 hours
  • 48 hours
  • Disabled

If it is set to "Disabled", manual filters update is still possible.

@ghost
Copy link

ghost commented Aug 10, 2019

From reddit user /u/sjhgvr:

Fully downloads every filterlist every 31 minutes even when they have not changed.
As a blocklist maintainer this really impacts server data use.
Start respecting e-tag / last-modified headers!
That said, you do support gzip (content encoding). I wish pi-hole would do that too.

(Source)

It is a good suggestion to start updating based on the headers, like other AdGuard products do for 'Automatic'. Perhaps an 'Automatic' option could be added?

I also would like to suggest adding '3 days', '5 days' and '1 week' to the list. Many list maintainers would prefer weekly updates as I mentioned in my previous comment.

@ameshkov
Copy link
Member

We'll push a small fix for v0.98: #929

@ghost
Copy link

ghost commented Aug 29, 2019

@ameshkov i noticed above your comment #641 (comment) describe my feature request #820 additionally if possible add option for manually update selected filters as well within v0.99 milestone 😊

@szolin
Copy link
Contributor

szolin commented Sep 4, 2019

What should be the update period value by default? 24 hours?

@ghost
Copy link

ghost commented Sep 4, 2019

Note what Pi-hole mentions:

Pi-hole checks for updates to the ad lists it uses once a week[...]

It’s not really necessary to check more often than that, and in some cases can be detrimental to you and/or the maintainer of the list. Many of the list maintainers institute a rate limit and if you exceed it, you won’t be able to download more updates from them. In addition, we suggest you respect the bandwidth of the list maintainers by not excessively downloading the lists.

For both of these reasons, Pi-hole will only download the lists if there is a difference between the locally cached version and the remotely hosted one.

Source: https://discourse.pi-hole.net/t/how-often-does-pi-hole-update-the-ad-lists/4383

I do personally agree with a longer period value, and when I view list author's comments, they keep telling users not to update too frequently.

If possible, I would suggest 1 week by default, or at the very least every 3 days (72 hours).

@ameshkov
Copy link
Member

ameshkov commented Sep 6, 2019

By default, we use AdGuard SDN filter which is updated much more often than once a week (or even a day).

So yeah, I guess we should use 24hrs for now.

@ghost
Copy link

ghost commented Sep 7, 2019

That makes sense @ameshkov. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants