Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support subdomain-based client configurations #780

Closed
alexzeitgeist opened this issue May 27, 2019 · 4 comments
Closed

Support subdomain-based client configurations #780

alexzeitgeist opened this issue May 27, 2019 · 4 comments
Labels
duplicate Duplicate or merged issues.

Comments

@alexzeitgeist
Copy link
Contributor

Currently, AdGuard Home has only one configuration for every client. It'd be nice if we could define different configurations based on the requested subdomain. For example:

client1.adguarddns.com loads filters and/or settings as configured for client1
client2.adguarddns.com loads filters and/or settings as configured for client2
etc.

with
adguarddns.com being the default.

@ameshkov
Copy link
Member

Hm, this could be really useful for the VPS-hosted AGH.

@alexzeitgeist
Copy link
Contributor Author

alexzeitgeist commented Jun 1, 2019

@ameshkov I just saw the latest commits regarding support for "clients" (#727). Seems like now it's a lot easier to add subdomain-based client configurations... basically, we would need to add a textfield to add a subdomain in the client configuration, and in the backend parse the Host request header. Of course, added logic would be needed, for example to prevent using the same subdomain for two different clients.

@ameshkov
Copy link
Member

ameshkov commented Jun 3, 2019

"Clients" settings do look relevant to this feature request, but I don't think this is the same entity.

Also, I think it would be useful to allow having different configurations based on the different server IP addresses (for those who use plain DNS).

and in the backend parse the Host request header

This would limit this feature to DOH. In the case of DOH or DOT, we should read the TLS connection's SNI extension.

@ameshkov ameshkov added duplicate Duplicate or merged issues. and removed P3: Medium feature request labels Jan 13, 2021
@ameshkov
Copy link
Member

Duplicate of #1383, to be implemented in v0.105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Duplicate or merged issues.
Projects
None yet
Development

No branches or pull requests

2 participants