Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Clients" settings section #727

Closed
ameshkov opened this issue Apr 23, 2019 · 13 comments
Closed

Add "Clients" settings section #727

ameshkov opened this issue Apr 23, 2019 · 13 comments
Assignees
Milestone

Comments

@ameshkov
Copy link
Member

ameshkov commented Apr 23, 2019

The idea is to have different client configurations.

Mockups:

Edit: I missed the Name field in the mockups.

Possible "client" identifiers:

  • IP address
  • Mac address

Mac address is useable only if AGH DHCP server is active.

What can be configured for a client:

  1. Blocking domains
  2. Browsing security
  3. Parental control
  4. Safe search
@rfgamaral
Copy link

I just want to add to this feature request that you should allow multiple IPs for the identifier and not just one. For instance, I have some clients on my network that make requests both in IPv4 and IPv6 and would love to categorized them both as the same client.

There's also another similar situation that is when you're using a VPN to access your home network or redirecting all traffic through your home connection. I have my VPN configured to use the AdGuard DNS server and all clients are identified by the VPN IP instead. So I need at least 2 IPv4 and one IPv6 identifier for a particular client.

Perhaps the IP field could support a mix of IPv4/IPv6 addresses and you could allow for that field to be a list of IPs, separated by commas, and not just a single IP.

Food for thought :)

@ameshkov
Copy link
Member Author

Hm, this might complicate things. @szolin thoughts?

@szolin
Copy link
Contributor

szolin commented May 20, 2019

I think we can support a list of IP addresses per client, but not in the upcoming release. We should start with just a single IP per client.

@Vansinnet
Copy link

Hello!

This feature is not working for me in 0.96. The client I have configured is filtered according to global rules (no security module, no parental controls and no enforced Safe Search), even though I set client to this:

2019-06-06

Is this a known issue or is there anything wrong on my end?

@ameshkov
Copy link
Member Author

ameshkov commented Jun 6, 2019

Just when I started thinking there will be a release without a hotfix following it :)

@szolin I can confirm, something is broken.

@ameshkov
Copy link
Member Author

ameshkov commented Jun 6, 2019

@Vansinnet the build with the fix is available in the beta channel - v0.96-3-g07db.

If nothing serious happens, we'll publish this fix to the release channel.

@rfgamaral
Copy link

I think we can support a list of IP addresses per client, but not in the upcoming release. We should start with just a single IP per client.

Since this issue is now closed, should I open an individual feature request for this?

@ameshkov
Copy link
Member Author

ameshkov commented Jun 7, 2019

Since this issue is now closed, should I open an individual feature request for this?

Yeah, unless #809 is what you want, then simply upvote it:)

@rfgamaral
Copy link

Yep, it's the same thing. thanks.

@rzcat
Copy link

rzcat commented Apr 30, 2020

@Vansinnet
did you solve your problem?
im running v0.101.0, with general settings "block domains use filters and hosts files" unchecked, checking "block domains use filters and hosts files" in client settings makes no effect

@Vansinnet
Copy link

Vansinnet commented May 1, 2020

Makes no effect? Do you mean the specific client isn't blocking advertisement in your scenario?

@Vansinnet
did you solve your problem?
im running v0.101.0, with general settings "block domains use filters and hosts files" unchecked, checking "block domains use filters and hosts files" in client settings makes no effect

@rzcat
Copy link

rzcat commented May 1, 2020

Makes no effect? Do you mean the specific client isn't blocking advertisement in your scenario?

@Vansinnet
did you solve your problem?
im running v0.101.0, with general settings "block domains use filters and hosts files" unchecked, checking "block domains use filters and hosts files" in client settings makes no effect

yes
general settings, unchecked, client settings, checked
use ip addr as identifier, specific client(my desktop) goes without filter
im wondering if anybody else has the same issue, or rather it's my config problem

@szolin
Copy link
Contributor

szolin commented May 6, 2020

@rzcat Please create a new task and describe your problem more in detail. This task is closed and we may forget to resolve your problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants