Rolling log files #1573

[DannyHinshaw]

This PR brings in the feature for rolling logs. Implemented by bringing in lumberjack as was suggested on the issue.

Additionally, new config file properties have been added to further configure the lumberjack output:

// logSettings
type logSettings struct {
	LogCompress   bool   `yaml:"log_compress"`    // Compress determines if the rotated log files should be compressed using gzip (default: false)
	LogLocalTime  bool   `yaml:"log_localtime"`   // If the time used for formatting the timestamps in is the computer's local time (default: false [UTC])
	LogMaxBackups int    `yaml:"log_max_backups"` // Maximum number of old log files to retain (MaxAge may still cause them to get deleted)
	LogMaxSize    int    `yaml:"log_max_size"`    // Maximum size in megabytes of the log file before it gets rotated (default 100 MB)
	LogMaxAge     int    `yaml:"log_max_age"`     // MaxAge is the maximum number of days to retain old log files
	LogFile       string `yaml:"log_file"`        // Path to the log file. If empty, write to stdout. If "syslog", writes to syslog
	Verbose       bool   `yaml:"verbose"`         // If true, verbose logging is enabled
}

[DannyHinshaw]

+golangci-lint run
home/home.go:9: File is not `goimports`-ed (goimports)
	"gopkg.in/natefinch/lumberjack.v2"

CI fail looks to be linter related. What is the proper way to fix this error?

[ameshkov]

CI fail looks to be linter related. What is the proper way to fix this error?

You may need to write something like

import (
    lumberjack "gopkg.in/natefinch/lumberjack.v2"
)

Also, I suggest installing golangci-lint locally and running it to see if there are any other linter issues like this.

[codecov-commenter]

Codecov Report

Merging #1763 into master will increase coverage by 0.00%.
The diff coverage is 29.41%.

@@           Coverage Diff           @@
##           master    #1763   +/-   ##
=======================================
  Coverage   38.76%   38.77%           
=======================================
  Files          61       61           
  Lines        8206     8220   +14     
=======================================
+ Hits         3181     3187    +6     
- Misses       4624     4630    +6     
- Partials      401      403    +2     

Impacted Files	Coverage Δ
home/config.go	47.47% <ø> (ø)
home/home.go	31.26% <29.41%> (+0.17%)	⬆️
util/auto_hosts.go	72.05% <0.00%> (+0.49%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ecd385...a066c95. Read the comment docs.

[ameshkov]

@DannyHinshaw thank you!

[DannyHinshaw]

@ameshkov you're welcome! Is it going to be merged? I'm unfamiliar with how the team processes PR's.

[szolin]

It's already merged!

[Freebase394]

Guys! Thanks so much for this "Feature"
Its so nice to have it on this project AdGuardHome and it's so usefull.

I love it!

I apologize for the inconvenience out of the blue, or for no reason!
I just wanted to say it, because those who contribute sometimes do not always receive the necessary recognition!
Thank you