Add web launcher for desktop users #1836
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the common review complaints about the snap when installed locally on a desktop or laptop, is that once installed, there's no desktop icon in the menu/launcher to get to the application. Many novice users expect this, even for web applications. We added this type of launcher for other snaps and they're well received.
So this PR adds a simple shell script which gets the current bind_port (if set) and launches a browser via the simple
xdg-open
, and if the config doesn't exist yet, it'll revert to the default port 3000. I modified both sets of snapcraft.yaml, the one for edge in root and the one under the packaging folder. Hopefully that's all okay. Tested here, and I get a nice Adguard Home icon in my launcher which just opens a browser window in my default desktop browser, as expected.