Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web launcher for desktop users #1836

Merged
merged 3 commits into from
Jul 17, 2020
Merged

Conversation

popey
Copy link
Contributor

@popey popey commented Jun 26, 2020

One of the common review complaints about the snap when installed locally on a desktop or laptop, is that once installed, there's no desktop icon in the menu/launcher to get to the application. Many novice users expect this, even for web applications. We added this type of launcher for other snaps and they're well received.

So this PR adds a simple shell script which gets the current bind_port (if set) and launches a browser via the simple xdg-open, and if the config doesn't exist yet, it'll revert to the default port 3000. I modified both sets of snapcraft.yaml, the one for edge in root and the one under the packaging folder. Hopefully that's all okay. Tested here, and I get a nice Adguard Home icon in my launcher which just opens a browser window in my default desktop browser, as expected.

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2020

Codecov Report

Merging #1836 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1836   +/-   ##
=======================================
  Coverage   39.21%   39.21%           
=======================================
  Files          63       63           
  Lines        8330     8330           
=======================================
  Hits         3267     3267           
  Misses       4656     4656           
  Partials      407      407           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a77dad...0297c12. Read the comment docs.

@ameshkov
Copy link
Member

Hmm, so people try to install it on their desktop machines?

In this case, there's another issue. Ubuntu's systemd-resolved by default is enabled and uses port 53. I reckon this is quite a problem for anyone who's trying to set up AGH on their desktop/laptop

@ameshkov ameshkov self-requested a review June 26, 2020 11:54
@ameshkov
Copy link
Member

@popey I'll take some time to test this change on a laptop with Ubuntu, thank you!

I'd appreciate if you could answer this question :)

@adguard adguard merged commit 8285847 into AdguardTeam:master Jul 17, 2020
@popey
Copy link
Contributor Author

popey commented Jul 17, 2020

Sorry, I missed the question. I didn't have a problem with that, during the adguard setup page I just told it to bind to my external IP (the wifi IP) and it works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants