Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: Fixed bug which was causing clients to continue following glo… #4983

Merged
merged 1 commit into from
Oct 3, 2022
Merged

bugfix: Fixed bug which was causing clients to continue following glo… #4983

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/home/dns.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,8 +335,6 @@ func applyAdditionalFiltering(clientIP net.IP, clientID string, setts *filtering
// pref is a prefix for logging messages around the scope.
const pref = "applying filters"

Context.filters.ApplyBlockedServices(setts, nil)

log.Debug("%s: looking for client with ip %s and clientid %q", pref, clientIP, clientID)

if clientIP == nil {
Expand All @@ -359,6 +357,8 @@ func applyAdditionalFiltering(clientIP net.IP, clientID string, setts *filtering

if c.UseOwnBlockedServices {
Context.filters.ApplyBlockedServices(setts, c.BlockedServices)
} else {
Context.filters.ApplyBlockedServices(setts, nil)
}

setts.ClientName = c.Name
Expand Down