Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counter.dev #1260

Closed
4 of 6 tasks
ihucos opened this issue Mar 14, 2023 · 12 comments
Closed
4 of 6 tasks

counter.dev #1260

ihucos opened this issue Mar 14, 2023 · 12 comments
Labels
A: Bug The issue is caused by a program bug A: In progress A: Waiting for data Waiting for more information from the user

Comments

@ihucos
Copy link

ihucos commented Mar 14, 2023

Prerequisites

  • This site DOES NOT contains sexually explicit material;
  • The problem occurs only when using AdGuard DNS or DNS filtering with AdGuard DNS filter, it is not caused by other ad blockers;
  • You're using an up-to-date version of AdGuard DNS filter;
  • Browser version is up-to-date;
  • If a website or an app is broken, disabling AdGuard DNS filter resolves the issue.

What DNS server do you use?

Other

Version

No response

What DNS upstream(s) do you use in AdGuard apps or AdGuard Home?

No response

What DNS filters do you have enabled?

I don't know

What browser or app do you use?

Other app

Which device type do you use?

Other device

What type of problem have you encountered?

Website or app doesn't work properly

Where did you encounter the problem?

https://counter.dev

Add your comment and screenshots

Hello,

counter.dev is an open source project that can also be found here: https://github.com/ihucos/counter.dev
That it is blocked was found unexpected by different users in hacker news here: https://news.ycombinator.com/item?id=35144256

Can we remove it from the list?

I am the maintainer of counter.dev and happy to help if needed.

Thanks!
blank

Privacy

  • I agree to follow this condition
@ihucos ihucos added the A: Bug The issue is caused by a program bug label Mar 14, 2023
@physx2494
Copy link

While the work you are doing is excellent, and by no means do I want to demotivate, the website is still, in one way or another, an analytics provider.

@ihucos
Copy link
Author

ihucos commented Mar 14, 2023

Correct, the website is a privacy friendly analytics provider. I thought the expected behaviour of a blocker would be to block activities like tracking - like done by "my" analytics provider. This bug would be about the entire website not displaying on the browser. Is that expected behaviour?

@physx2494
Copy link

physx2494 commented Mar 14, 2023 via email

@Alex-302
Copy link
Member

Alex-302 commented Mar 15, 2023

@ihucos Is it possible to use a sub-domain for tracking purposes? Like t.counter.dev. In this case we could block tracking without blocking the main domain.

I see your script is used as inline script, so not "instead", but as a different solution.

Details
    <script type="text/javascript">
        /*<![CDATA[*/
        if (!sessionStorage.getItem("_swa") && document.referrer.indexOf(location.protocol + "//" + location.host) !== 0) {
            fetch("https://counter.dev/track?" + new URLSearchParams({
                referrer: document.referrer,
                screen: screen.width + "x" + screen.height,
                user: "marcondesmacaneiro",
                utcoffset: "-3"
            }))
        }
        ;sessionStorage.setItem("_swa", "1");
        /*]]>*/
    </script>

@ihucos
Copy link
Author

ihucos commented Mar 15, 2023

Yes, absolutely! I will change the tracking script to to request t.counter.dev (That subdomain naming makes sense). There are some legacy integrations that used the inline script but they will fade out with time.

I'll let you know when its done.

@Alex-302
Copy link
Member

Great, thanks)

@Alex-302 Alex-302 added the A: Waiting for data Waiting for more information from the user label Mar 16, 2023
@ihucos
Copy link
Author

ihucos commented Mar 31, 2023

I had to be careful to not disturb the service. It is done. The tracking script now calls t.counter.dev which can be added to the blocklist. counter.dev - the website itself - can then be allow-listed.

To verify check:
https://cdn.counter.dev/script.js
https://github.com/ihucos/counter.dev/blob/master/docs/script.js

Thank you very much and let me know if there are any questions.

@ameshkov
Copy link
Member

@ihucos

Quick question: the privacy conscious users will be triggered by a third-party script loading on websites so we'll need to block cdn.counter.dev as well. Will it be an issue for the website functions?

@ihucos
Copy link
Author

ihucos commented Mar 31, 2023

Hello ameshkov,

thank you very much for asking.

Will it be an issue for the website functions?

No, that is only used to serve the tracking script, feel free to block it.

@Alex-302
Copy link
Member

feel free to block it.

t.counter.dev and whole cdn.counter.dev?

@ihucos
Copy link
Author

ihucos commented Mar 31, 2023

Yes, confirm.

Alex-302 added a commit to AdguardTeam/AdguardFilters that referenced this issue Apr 1, 2023
@Alex-302
Copy link
Member

Alex-302 commented Apr 1, 2023

@ihucos Thanks! Fixed in the regular filter and created the pull-request in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Bug The issue is caused by a program bug A: In progress A: Waiting for data Waiting for more information from the user
Projects
None yet
Development

No branches or pull requests

4 participants