Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix https://github.com/AdguardTeam/AdguardFilters/issues/145369 #1257

Merged
merged 2 commits into from
Mar 15, 2023

Conversation

Yuki2718
Copy link
Contributor

Prerequisites

To avoid invalid pull requests, please check and confirm following terms

  • This is not an ad/bug report
  • My code follows syntax of this project
  • I have performed a self-review of my own changes
  • My changes do not break web sites, apps and files structure

What problem does the pull request fix?

If the problem does not fall under any category that is listed here, please write a comment below in corresponding section

  • Missed ads
  • Website or app doesn't work properly
  • Missed analytics or tracker
  • Filters maintenance

What issue is being fixed?

Enter the issue address

AdguardTeam/AdguardFilters#145369
AdguardTeam/AdguardFilters#84106 (comment)

Terms

  • By submitting this issue, I agree that pull request does not contain private info and all conditions are met

@Alex-302
Copy link
Member

Can't reproduce.

@Yuki2718
Copy link
Contributor Author

I can reproduce, if you scroll, contents should be loaded inifinitely. But with this blocked, it's finite.

@Alex-302
Copy link
Member

I'm not sure if it is worth removing the rule because of one problem in the absence of complaints.

@Yuki2718
Copy link
Contributor Author

Well, two: AdguardTeam/AdguardFilters#84106 (comment)
Movie broken by the rule. Actually this may be more important - AdguardTeam/AdguardFilters#145369 is not too serious TBH.

@Alex-302
Copy link
Member

Ok

@Alex-302 Alex-302 merged commit 3c5500b into AdguardTeam:master Mar 15, 2023
@Yuki2718 Yuki2718 deleted the fix/AGF145369 branch March 15, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants