Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot move external rules editor to the main browser's window #2379

Closed
Alex-302 opened this issue Jun 21, 2023 · 2 comments
Closed

Cannot move external rules editor to the main browser's window #2379

Alex-302 opened this issue Jun 21, 2023 · 2 comments

Comments

@Alex-302
Copy link
Member

AdGuard Extension version

4.2.133

Browser version

Version 114.0.5735.134

OS version

Windows 10 x64

What filters do you have enabled?

No response

What Stealth Mode options do you have enabled?

No response

Issue Details

In 4.1 external filter editor opened in a new window as a tab. Now it opens as separate window, and can't be moved to the main window.
To work with the rules it is convenient to keep the editor in a separate pinned tab.

Expected Behavior

No response

Screenshots

4.1 vs 4.2

image

image

Additional Information

No response

@XX-J
Copy link

XX-J commented Jul 21, 2023

Во всех версиях AdGuard 4.2.xxx на FireFox'e v78.13 ESR кнопка открытия внешнего редактора правил не работает!

Screenshot:

2023-07-21-1

Консоль страницы настроек выдаёт следующую ошибку:

    Uncaught (in promise) Error: Type error for parameter createData (Property "focused" is unsupported by Firefox) for windows.create.          background.js
    openEditorFullscreen      moz-extension://ede33548-d89b-415c-aa4f-140c0ba03277/pages/options.js:11980
    AsyncFunctionThrow      self-hosted:697
Screenshot:

2023 07 23-1

@maximtop
Copy link
Contributor

Во всех версиях AdGuard 4.2.xxx на FireFox'e v78.13 ESR кнопка открытия внешнего редактора правил не работает!

Screenshot:
Консоль страницы настроек выдаёт следующую ошибку:

    Uncaught (in promise) Error: Type error for parameter createData (Property "focused" is unsupported by Firefox) for windows.create.          background.js
    openEditorFullscreen      moz-extension://ede33548-d89b-415c-aa4f-140c0ba03277/pages/options.js:11980
    AsyncFunctionThrow      self-hosted:697

Screenshot:

заведите под эту проблему отдельную задачу, будем смотреть почему в прошлых версиях не работает

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants