Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot apply CSS rules inside iframe #2420

Closed
Alex-302 opened this issue Aug 2, 2023 · 6 comments
Closed

Cannot apply CSS rules inside iframe #2420

Alex-302 opened this issue Aug 2, 2023 · 6 comments

Comments

@Alex-302
Copy link
Member

Alex-302 commented Aug 2, 2023

AdGuard Extension version

4.2.142

Browser version

114

OS version

Windows 10

What filters do you have enabled?

AdGuard Base filter, AdGuard Mobile Ads filter, AdGuard French filter

What Stealth Mode options do you have enabled?

Block trackers, Remove tracking parameters, Hide your search queries, Send websites signals not to track you, Self-destruction of third-party cookies, Self-destruction of first-party cookies, Hide Referrer from third parties, Remove X-Client-Data header, Disable WebRTC

Issue Details

URL: https://maxppp.com/
Rules:

maxppp.com#$#.cdk-overlay-container { display: none !important; }
maxppp.com#$#body.gb-global-scrollblock { overflow: auto !important; }
Screenshot 1:

image

Screenshot 2 - the rules above are not applied:

image

Expected Behavior

Popup must be hidden.

Screenshots

No response

Additional Information

No issues with AdGuard apps.

@Alex-302 Alex-302 added the Bug label Aug 2, 2023
@maximtop
Copy link
Contributor

maximtop commented Aug 2, 2023

The same problem is on the v4.1 too.

@AdamWr
Copy link
Member

AdamWr commented Aug 11, 2023

It seems that the similar issue occurs with version 4.2.151, related to - AdguardTeam/AdguardFilters#158843

Ad marked on the screenshot below should be hidden by ##.playerinads rule, but it doesn't work.

Screenshot 1

image

The problem doesn't occur when website is loaded, but if you click on a different video player, for example "Vidmoly" (marked on the screenshot below) and again on "Roll+", then rules are not applied to iframe.

Screenshot 2

image

Steps to reproduce:
Website is geo-locked, Turkish IP is required

  1. Add this rule:
 contentx.me#%#alert(1);
  1. Go to - https://diziroll.co/dizi/what-we-do-in-the-shadows/sezon-5/bolum-6
  2. Alert will be displayed, it's okay
  3. Click on Vidmoly button (marked on screenshot 2 above)
  4. Click on Roll+ button
  5. There should be an alert again, but it doesn't work

It looks like that in this case it works correctly with version 4.1.57.

@kodiakhub
Copy link

@AdamWr can you check again? 4.2.159 beta doesn't fix it. Switch between 'Roll+' and 'Vidmoly' video player.

@maximtop
Copy link
Contributor

maximtop commented Aug 28, 2023

4.2.159 beta doesn't fix it.

the task is still open

@kodiakhub
Copy link

kodiakhub commented Aug 28, 2023

the task is still open

I understand 👍 but unfortunately when i saw that it was fixed in the new beta version, i thought so. I wish there was a clearer explanation on this. After all, we are testing. 😄

image


Btw, this change is confusing as it shows both added and removed. Isn't that wrong? 😄

image

@maximtop
Copy link
Contributor

It's a bot; I suggest watching the results.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants