Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specific rules not applied in the new tab on the first opening #2459

Closed
AdamWr opened this issue Aug 29, 2023 · 6 comments
Closed

Specific rules not applied in the new tab on the first opening #2459

AdamWr opened this issue Aug 29, 2023 · 6 comments

Comments

@AdamWr
Copy link
Member

AdamWr commented Aug 29, 2023

AdGuard Extension version

4.2.159

Browser version

Chrome 116

OS version

Windows 11

What filters do you have enabled?

AdGuard Base filter

What Stealth Mode options do you have enabled?

No response

Issue Details

Related to - AdguardTeam/AdguardFilters#160293

It looks like that CSS exceptions do not work after closing and then opening the same website.

Steps to reproduce:

  1. Add these rules:
##body
example.org#@#body
  1. Go to - https://example.org/
  2. Close current tab
  3. Open new tab and again navigate to - https://example.org/

Website is blank, exception rule is not applied.

Video
Recording.2023-08-29.095634.mp4

Expected Behavior

example.org#@#body should be applied and content should be visible.

Screenshots

No response

Additional Information

No response

@AdamWr
Copy link
Member Author

AdamWr commented Aug 29, 2023

It seems that it's not only about element hide exceptions rules.
The same happens with JavaScript rules, for example:

example.org#%#alert(1);

though it seems that for some reasons it's a bit harder to reproduce and doesn't occur as often as issue with exceptions.

@adguard-bot adguard-bot assigned zhelvis and unassigned Birbber Aug 29, 2023
@AdamWr AdamWr changed the title Element hide exception does not work sometimes Some specific rules are not applied sometimes Aug 29, 2023
@kodiakhub
Copy link

Is it the same as the issue here? 👉 #1772 (comment)

If not, please mark it as off-topic. 👍

@AdamWr
Copy link
Member Author

AdamWr commented Aug 29, 2023

Is it the same as the issue here?

This one is rather a new issue and it probably didn't occur in previous version, I suppose it's not related to mentioned issue.

I guess that in the case of #1772 it could have been a race condition and scriptlet was executed too late, but I'm just guessing.

@Yuki2718
Copy link

Yuki2718 commented Aug 29, 2023

I observed similar behavior, but in my case I simply refreshed the page and excpetion didn't work. But when I tried to reproduce to report, the trouble dissapeared.

@Alex-302
Copy link
Member

Maybe related to this issue - sometimes, when I open Youtube in a new tab and open some (popupar) video, I see only blocked URLs in the filtering log, and video ads are not blocked.

Details

image

@zloyden
Copy link

zloyden commented Aug 31, 2023

Actually, I don't know if it's related to this issue or not, but I've seen the similar behaviour on pikabu.ru. Looks like the scriptlet rule does not apply when you open a new tab, but after refreshing the scriptlet shows on the console and works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants